Fix false positive readability/braces warning for trailing comma on c… - #229
Closed
jordancharest wants to merge 1 commit into
Closed
Fix false positive readability/braces warning for trailing comma on c…#229jordancharest wants to merge 1 commit into
jordancharest wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
CI failure Traceback (most recent call last):
File "setup.py", line 87, in <module>
'lint': Lint
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/__init__.py", line 87, in setup
return distutils.core.setup(**attrs)
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/_distutils/core.py", line 177, in setup
return run_commands(dist)
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/_distutils/core.py", line 193, in run_commands
dist.run_commands()
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 968, in run_commands
self.run_command(cmd)
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/dist.py", line 1217, in run_command
super().run_command(command)
File "/home/runner/work/cpplint/cpplint/.tox/python3.7/lib/python3.7/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
cmd_obj.run()
File "/home/runner/work/cpplint/cpplint/.eggs/pytest_runner-5.2-py3.7.egg/ptr.py", line 209, in run
return self.run_tests()
File "/home/runner/work/cpplint/cpplint/.eggs/pytest_runner-5.2-py3.7.egg/ptr.py", line 220, in run_tests
result_code = __import__('pytest').main()
File "/home/runner/work/cpplint/cpplint/.eggs/pytest-7.4.0-py3.7.egg/pytest/__init__.py", line 5, in <module>
from _pytest._code import ExceptionInfo
File "/home/runner/work/cpplint/cpplint/.eggs/pytest-7.4.0-py3.7.egg/_pytest/_code/__init__.py", line 2, in <module>
from .code import Code
File "/home/runner/work/cpplint/cpplint/.eggs/pytest-7.4.0-py3.7.egg/_pytest/_code/code.py", line 35, in <module>
import pluggy
File "/home/runner/work/cpplint/cpplint/.eggs/pluggy-1.3.0-py3.7.egg/pluggy/__init__.py", line 23, in <module>
from ._manager import PluginManager, PluginValidationError
File "/home/runner/work/cpplint/cpplint/.eggs/pluggy-1.3.0-py3.7.egg/pluggy/_manager.py", line 3, in <module>
import importlib.metadata
ModuleNotFoundError: No module named 'importlib.metadata'
Error: ERROR: InvocationError for command /home/runner/work/cpplint/cpplint/.tox/python3.7/bin/python setup.py test (exited with code 1)
___________________________________ summary ____________________________________
Error: ERROR: python3.7: commands failed
Error: Process completed with exit code 1.
|
Sorry, something went wrong.
aaronliu0130
requested changes
Mar 31, 2024
aaronliu0130
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Would you kindly write some tests? Also, I doubt that this would work on multi-line concepts. Maybe we could take some inspiration from structs' detection.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oncepts.
Currently a readability/braces error is triggered for C++20 concepts. This change ignores trailing semi-colons that follow concept definitions.