Fix false positive on concept declaration - #288
Conversation
Sorry, something went wrong.
aaronliu0130
left a comment
There was a problem hiding this comment.
This is a massive step up, though there is the very rare case of an identifier being named "requires" and the user linting a pre-C++20 file. It would be great if we could work out a way to also require the "concept" keyword, but I would be happy to merge this as-is if you can't figure it out.
Sorry, something went wrong.
|
If I understand correctly, the only issue with someone using requires as a name, is it would result in }; not being detected. If my assumption is correct, I don't think it's a huge issue. One way to go about fixing that is to go through the preceding lines and look for concept. The hard question is when to stop. Do we look for a semi-colon, empty line? |
Sorry, something went wrong.
|
Yeah, that's what I meant. Like I said, it's probably not really an issue if we don't see a good way.. |
Sorry, something went wrong.
My attempt to fix #225, since #229 seems to be dead.
I used a requires keyword for concept detection, as the concept keyword could be a few lines above the opening brace.
Not 100% on the regex, so if someone could check it, I would appreciate it.