FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop Python 3.8 by aaronliu0130 · Pull Request #334 · cpplint/cpplint · GitHub

Drop Python 3.8 - #334

Merged
cclauss merged 7 commits into
cpplint:developfrom
aaronliu0130:drop
Apr 7, 2025
Merged

Drop Python 3.8#334
cclauss merged 7 commits into
cpplint:developfrom
aaronliu0130:drop

Conversation

Copy link
Copy Markdown
Member

Pylint released their update on dedeprecating the getopt and optparse modules.Should merge this after we release 2.0.1.

Copy link
Copy Markdown
Member Author

Does not compute. Pylint 3.3.5 is available for PyPy 3.11 on Linux and macOS but not Windows‽

cclauss commented Mar 18, 2025

Copy link
Copy Markdown
Member

Does not compute. Pylint 3.3.5 is available for PyPy 3.11 on Linux and macOS but not Windows‽

Yes, unfortunately correct... pylint-dev/pylint#10286 (review)

aaronliu0130 commented Mar 19, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

Pylint successfully installs and runs with PyPy3.11 on my Windows VM, but not on GitHub's apparently.

cclauss commented Mar 19, 2025

Copy link
Copy Markdown
Member

aaronliu0130 marked this pull request as ready for review April 3, 2025 02:16

Copy link
Copy Markdown
Member Author

We could ignore the pypy3.11 issue for a while until release where maybe we can decide to just yank the pypy3.11 tests. Either way, this should be the next PR merged before any changelog-worthy changes so we have updated changelog and version entries.

aaronliu0130 requested review from cclauss and jayvdb April 3, 2025 02:26
aaronliu0130 changed the title [Do NOT Merge] drop Python 3.8 Drop Python 3.8 and Bump version Apr 3, 2025
aaronliu0130 changed the title Drop Python 3.8 and Bump version Drop Python 3.8 | bump version Apr 3, 2025
Comment thread pyproject.toml Outdated
Comment thread CHANGELOG.rst Outdated
Comment thread cpplint.py Outdated
Comment thread pyproject.toml Outdated
"mypy",
"parameterized",
"pylint>=2.11",
"pylint==3.3.5",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
"pylint==3.3.5",
"pylint>=3.3.4",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am surprised that this works since the dedeprecation only happens in pylint 3.3.5 and the pypy3.11 logs indicate that it installs 3.3.4.

cclauss merged commit 777a8a7 into cpplint:develop Apr 7, 2025

cclauss commented Apr 7, 2025
edited
Loading

Copy link
Copy Markdown
Member

What is release vNEXT? Is it v2.0.2, v2.1.0, or v3.0.0? Different pull requests making different guesses is suboptimal (git conflicts). It is best to make the vNEXT version number decision at release time. v2.0.1 is preserved at:

aaronliu0130 commented Apr 7, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks for the review! I would appreciate it if I or someone else had the chance to review your changes before they are unilaterally merged, though. (Not that that means a PR should be stuck just because the author didn't reply to changes; 24 hours should be enough.)

aaronliu0130 changed the title Drop Python 3.8 | bump version Drop Python 3.8 Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL