| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
changelog for this force push
|
Sorry, something went wrong.
changelog for this force push
Previous actions run (success): https://github.com/cpplint/cpplint/actions/runs/14022517156?pr=353 |
Sorry, something went wrong.
|
In our code base it solves the issues with members initializers, but there is one issue remaining: #include "types.hpp"
namespace opossum {
namespace hana = boost::hana;
namespace detail {
// Extends to hana::make_tuple(hana::type_c<int32_t>, hana::type_c<int64_t>, ...);
static constexpr auto types =
hana::make_tuple(BOOST_PP_SEQ_ENUM(BOOST_PP_SEQ_TRANSFORM(EXPAND_TO_HANA_TYPE, _, data_types_macro)));
cpplint complains about the last line. |
Sorry, something went wrong.
|
I don't think we would bother with that, unfortunately... catching that would probably make cpplint way slower and the usual linesplitting AFAIK is to split inside the parentheses like static constexpr auto types = hana::make_tuple(BOOST_PP_SEQ_ENUM(
BOOST_PP_SEQ_TRANSFORM(EXPAND_TO_HANA_TYPE, _, data_types_macro)));which is also what clang-format with Google style gives you. |
Sorry, something went wrong.
|
Okay, we'll just NOLINT this line then. Thanks for the quick fix with this PR! |
Sorry, something went wrong.
force-push changelog
|
Sorry, something went wrong.
| src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] | ||
| src/inspect/unnamed_namespace_check.hpp:29: Do not indent within a namespace. [whitespace/indent_namespace] [4] | ||
| src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] | ||
| src/inspect/unnamed_namespace_check.hpp:30: Do not indent within a namespace. [whitespace/indent_namespace] [4] |
There was a problem hiding this comment.
This is technically a false negative, but it's due to the already-violation that is whitespace/braces so I don't think it's worth the extra compute tradeoff to support.
Sorry, something went wrong.
|
Rebase includes typo fix. Pls review |
Sorry, something went wrong.
|
This has now been sitting here for 2 weeks. I can rebase after #334 is merged to add a new changelog section. |
Sorry, something went wrong.
|
Please resolve the git conflict in CHANGELOG.rst, and then I will approve this pull request. |
Sorry, something went wrong.
|
Great! Thanks. However rebasing is blocked by #334, which would bump the version and add a new block in the changelog. |
Sorry, something went wrong.
|
#334 is now merged. Updating the version should only be done in the release process, not before. Modifying CHANGELOG.rst is always dicey because of git conflicts. My recommendation would be that new entries only pertain to the current pull request. Put a blank line before and after all new entries (to decrease the possibility of git conflicts). At release time, we can update the version and remove the blank lines.
When releasing, we will:
|
Sorry, something went wrong.
In my opinion, it is worse. It can falsely confuse users (and support agents) into thinking the trunk software is on the latest stable release, and the only "benefit" of only updating the version on release is not needing to debate the version number. Nearly every major project I know bumps the version number immediately after release. I also do not see different PRs making different guesses on the version number, and it bumps the semver feature part as I feel like we should have at least e.g. #64 in the next release. Maybe we should just put a temporary version number (e.g. 2.0.1-next for right after releasing 2.0.1) in cpplint.py and leave the new CHANGELOG header as "TBA"? I like your blank lines idea, though. |
Sorry, something went wrong.
Split out parentheses counting namespace consumption to have enough available conditional branches for next commit Add type hints # Conflicts: # cpplint.py
Fix whitespace/indentation_namespace false positive for member initializer lists (MemInitLists) Adds new _ConstructorInfo, _WrappedInfo, and _MemInitListInfo nesting stack element classes Remember last-popped nesting stack item Update descriptor.pb.cc to 2016-12-16 version (commit 183d31c)
|
https://github.com/pydantic/pydantic/blob/04fd6395c7165232785992a6ad0e817e9db6e590/pydantic/version.py#L9 Same as the recent release made four days ago. Preparing for tomorrow’s release of Celery celery/celery#9660 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Should fix #346
A massive commit for a seemingly simple problem!
Fix whitespace/indentation_namespace false positive for member initializer lists (MemInitLists)
Adds new _ConstructorInfo, _WrappedInfo, and _MemInitListInfo nesting stack element classes
Remember last-popped nesting stack item
Update descriptor.pb.cc to 2016-12-16 version (commit 183d31c)
chore: refactor part of NestingState.Update()
Split out parentheses counting namespace consumption to have enough available conditional branches for next commit
Add type hints