| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This pull request updates the configuration to enable flake8-todos support and revises TODO comments in the Python code to include a username.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Enables flake8-todos and adjusts ignore settings for todo-checking. |
| cpplint_clitest.py | Updates a TODO comment to include a username placeholder. |
| cpplint.py | Updates multiple TODO comments to include a username placeholder. |
cpplint_clitest.py:66
# TODO(unknown): Support scenario with multiple input names
cpplint.py:4248
# TODO(unknown): support alternate operators
cpplint.py:4770
# TODO(unknown): Err on if...else and do...while statements without braces;
cpplint.py:7460
# TODO(unknown): Maybe make this have an exit code of 2 after all is done
Sorry, something went wrong.
There was a problem hiding this comment.
What is the point of making these changes if they just going to silence/workaround it by making it all unknown? How does this provide a point of reference for the best context? To do this, we should correctly blame all the TODOs. (BTW, since we check all the flake8 rules we check with ruff too, I think we can go ahead with removing flake8 from pre-commit.)
(psssst: I hate to sound like a broken record, but I'd really appreciate a review for #353.)
Sorry, something went wrong.
|
Also, what do you think of enabling CodeRabbit? It's like the Copilot review you just requested and free for public repos, plus it replies to and learns from the replies you give its suggestions. |
Sorry, something went wrong.
|
Never heard of CodeRabbit but will take a look. |
Sorry, something went wrong.
|
This is a rule that both cpplint and ruff have this rule for good reasons. I believe that we should implement it for future TODOs. I cannot properly assign old TODOs (without a lot of git blame) but adding this rule now will help us (in the code review process) ensure that new TODOs have assignees. |
Sorry, something went wrong.
|
I don't see how the original commit would've incentivized that instead of just making TODOs say "TODO(unknown)" instead. Anyways, this issue is moot now as I've just taken a few minutes to blame the TODOs; it's much easier if you use the blame feature in an IDE instead of manually running git commands. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
% ruff rule TD002 # https://docs.astral.sh/ruff/rules/missing-todo-author