Repository navigation
If BuildImage fails but logs something about success, don't succeed - #2305
Merged
eddumelendez merged 1 commit intoFeb 26, 2024
Merged
eddumelendez merged 1 commit into
eddumelendez merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building. Fixes docker-java#2184
Copy link
Copy Markdown
Contributor
Author
|
Tested by running integration tests (except swarm), and building a local snapshot, build downstream gradle-docker-plugin, and validating that a pip install command followed by a failing command doesn't result in success. |
Sorry, something went wrong.
eddumelendez
approved these changes
Feb 26, 2024
Copy link
Copy Markdown
Member
|
Thanks for your contribution, @niloc132 ! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that if the docker build commands result in logging the string "Successfully built", the callback from that build will still fail if there was an error in building.
Fixes #2184