Repository navigation
Fix: Second execution of a docker command in Netty implementation always fails - #630
Merged
marcuslinke merged 2 commits intoJul 9, 2016
Merged
marcuslinke merged 2 commits into
marcuslinke merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@KostyaSha tests initialization fails with the response from Docker: {"message":"starting container with HostConfig was deprecated since v1.10 and removed in v1.12"}. I'm not sure if it is my fault. Could you please check? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
docker-java isn't adopted to 1.24 yet. Working on it but firstly need end #620 , then IT on 1.11 docker version would work right. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@tejksat Thanks for your contribution! LGTM. |
Sorry, something went wrong.
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* Fix for docker-java#625 * Checkstyle errors fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unable to setup a valuable integration test because TestDockerCmdExecFactory changes default DockerCmdExecFactoryImpl behavior in the way it becomes pointless. It creates WebTarget on every exec() invocation:
"main@1" prio=5 tid=0x1 nid=NA runnable java.lang.Thread.State: RUNNABLE at com.github.dockerjava.netty.WebTarget.<init>(WebTarget.java:28) at com.github.dockerjava.netty.DockerCmdExecFactoryImpl.getBaseResource(DockerCmdExecFactoryImpl.java:577) at com.github.dockerjava.netty.DockerCmdExecFactoryImpl.createCreateContainerCmdExec(DockerCmdExecFactoryImpl.java:396) at com.github.dockerjava.core.TestDockerCmdExecFactory$1.exec(TestDockerCmdExecFactory.java:103) at com.github.dockerjava.core.TestDockerCmdExecFactory$1.exec(TestDockerCmdExecFactory.java:100) at com.github.dockerjava.core.command.AbstrDockerCmd.exec(AbstrDockerCmd.java:35) at com.github.dockerjava.core.command.CreateContainerCmdImpl.exec(CreateContainerCmdImpl.java:177) ...This change is