fix: ensure message content is not modified by header filter - #4425
Closed
mpldr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Due to an oversight, one of the header filters has potentially modified the message body, leading to broken cryptographic signatures. Switch to the Message-Id instead of the Content-Type header, which is usually only present in the global header. Signed-off-by: Moritz Poldrack <git@moritz.sh> Reported-by: Cole Young <cole@young.sh> Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
Copy link
Copy Markdown
Contributor
Author
DescriptionType of change
Checklist
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM 👍 Can you adjust the corresponding tests, do you require any further assistance? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I would like to ask for assistance in that… I dont quite see how my patch would affect [Network - Hostname] should update configuration correctly (Standard FQDN setup). After all the message id is not removed, it is just moved down a line. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
No worries, I will have a look and try to help. |
Sorry, something went wrong.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an oversight, one of the header filters has potentially modified the message body, leading to broken cryptographic signatures.
Switch to the Message-Id instead of the Content-Type header, which is usually only present in the global header.
Reported-by: Cole Young cole@young.sh
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (#4120)")