FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Prevent Microsoft MUAs from sending reactions by mpldr · Pull Request #4120 · docker-mailserver/docker-mailserver · GitHub

chore: Prevent Microsoft MUAs from sending reactions - #4120

Merged
polarathene merged 2 commits into
docker-mailserver:masterfrom
mpldr-pulls:patch-1
Jul 22, 2024
Merged

chore: Prevent Microsoft MUAs from sending reactions#4120
polarathene merged 2 commits into
docker-mailserver:masterfrom
mpldr-pulls:patch-1

Conversation

mpldr commented Jul 18, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Microsoft added a way to "react" to emails which is turned into

[Image] liked this message.

No MUA except Microsoft's latest ones displays these properly and they are not providing significant value to an Email-exchange.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Comment thread CHANGELOG.md Outdated
georglauterbach added service/postfix kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) labels Jul 21, 2024
georglauterbach added this to the v14.1.0 milestone Jul 21, 2024
casperklein previously approved these changes Jul 21, 2024

casperklein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am ambivalent about this PR. Personally I don't like that MS feature. But I am also not a fan of including app specific hacks into DMS.

For me, it would be fine to do such things via user-patches.sh.

mpldr commented Jul 21, 2024

Copy link
Copy Markdown
Contributor Author

But I am also not a fan of including app specific hacks into DMS.

Me neither, but if a multi-billion dollar corporation feels like undermining standards, we – as in people invested in keeping the technology open and accessible – should make sure that this does not work with our systems. Google pulled something similar with XMPP and I would find it sad, if Microsoft did it to Email.

polarathene previously approved these changes Jul 21, 2024

Copy link
Copy Markdown
Member

We do not have the permission to rebase or merge master to update your branch, you'll need to update your branch again. Conflict would be from a recent PR that updated the CHANGELOG.md.

If the PR here doesn't cause any issues for users (I don't know if it makes sense to expect the feature compatibility with DMS), merging is fine. Otherwise I'd agree with @casperklein and just add a tip in our docs about it with user-patches.sh.

mpldr added 2 commits July 22, 2024 12:37
No one in their right mind would want this, so we can probably just drop it.
Signed-off-by: Moritz Poldrack <~git@mp.gy>
polarathene changed the title Prevent Microsoft MUAs from sending reactions chore: Prevent Microsoft MUAs from sending reactions Jul 22, 2024
polarathene merged commit 009237c into docker-mailserver:master Jul 22, 2024
georglauterbach modified the milestones: v14.1.0, v15.0.0 Sep 26, 2024
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 23, 2025
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <git@moritz.sh>
Reported-by: Cole Young <cole@young.sh>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 24, 2025
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <git@moritz.sh>
Co-Authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Reported-by: Cole Young <cole@young.sh>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
mpldr added a commit to mpldr-pulls/docker-mailserver that referenced this pull request Mar 25, 2025
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <git@moritz.sh>
Co-Authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Reported-by: Cole Young <cole@young.sh>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration (file) kind/improvement Improve an existing feature, configuration file or the documentation service/postfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL