FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: ensure message content is not modified by header filter by mpldr · Pull Request #4429 · docker-mailserver/docker-mailserver · GitHub

/ docker-mailserver Public

fix: ensure message content is not modified by header filter - #4429

Merged
georglauterbach merged 1 commit into
docker-mailserver:masterfrom
mpldr-pulls:master
Mar 25, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: ensure message content is not modified by header filter#4429
georglauterbach merged 1 commit into
docker-mailserver:masterfrom
mpldr-pulls:master

Conversation

mpldr commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

Due to an oversight, one of the header filters has potentially modified the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is usually only present in the global header.

Reported-by: Cole Young cole@young.sh
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (#4120)")

mpldr mentioned this pull request Mar 24, 2025
Closed
8 tasks
georglauterbach self-requested a review March 24, 2025 13:26
polarathene requested changes Mar 25, 2025
View reviewed changes

polarathene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM thanks, just an improvement to the changelog.

Comment thread CHANGELOG.md Outdated
polarathene added this to the v15.0.2 milestone Mar 25, 2025
casperklein previously approved these changes Mar 25, 2025
View reviewed changes
fix: ensure message content is not modified by header filter
e713cb5 
Due to an oversight, one of the header filters has potentially modified
the message body, leading to broken cryptographic signatures.

Switch to the Message-Id instead of the Content-Type header, which is
usually only present in the global header.

Signed-off-by: Moritz Poldrack <git@moritz.sh>
Co-Authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
Reported-by: Cole Young <cole@young.sh>
Fixes: 009237c ("chore: Prevent Microsoft MUAs from sending reactions (docker-mailserver#4120)")
mpldr dismissed stale reviews from casperklein and georglauterbach via e713cb5 March 25, 2025 21:37

mpldr commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

Done as requested :)

casperklein commented Mar 25, 2025

Copy link
Copy Markdown
Member

Not related to this PR: Does anyone knows, why there are these \s* in the regex? If never saw mail headers prefixed by space(s).

georglauterbach commented Mar 25, 2025

Copy link
Copy Markdown
Member

Not related to this PR: Does anyone knows, why there are these \s* in the regex? If never saw mail headers prefixed by space(s).

I don't know either. I'll revise this after afterward anyway, the whitespaces are very likely not required.

georglauterbach enabled auto-merge (squash) March 25, 2025 23:04

polarathene commented Mar 25, 2025

Copy link
Copy Markdown
Member

I'll revise this after afterward anyway, the whitespaces are very likely not required.

FWIW, I did investigate this feature in DMS and it looks like it had a poor implementation to begin with: #4263 (comment)

AFAIK, this was intended only for affecting mail sent from Postfix, but looks like it was misconfigured to also apply to mail arriving to Postfix to give to Dovecot.

georglauterbach merged commit c2c48b2 into docker-mailserver:master Mar 25, 2025
polarathene mentioned this pull request Mar 25, 2025
Open
61 tasks

georglauterbach commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Do we want to release v15.0.2 right away?

mpldr commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

Not sure how frequently its encountered, but I would think those who are would very much appreciate a timely fix.

polarathene commented Mar 26, 2025

Copy link
Copy Markdown
Member

Do we want to release v15.0.2 right away?

Given the regression that'd be wise to do. Anything else that props up over the next week can go into a .3 release if needed before merging in changes for 15.1.

georglauterbach commented Mar 26, 2025

Copy link
Copy Markdown
Member

ref #4432

polarathene mentioned this pull request Nov 21, 2025
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

casperklein casperklein approved these changes
polarathene polarathene approved these changes
georglauterbach georglauterbach approved these changes

Assignees

mpldr

Labels

area/configuration (file) kind/bug/fix A fix (PR) for a confirmed bug priority/high service/postfix

Projects

None yet

Milestone

v15.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL