This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Replace psycopg2-binary with psycopg2 (#198) - #204
Merged
lovelydinosaur merged 1 commit intoMay 1, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lovelydinosaur
approved these changes
May 1, 2020
lovelydinosaur
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yup, thanks.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Just a drive-by comment that this change probably needs a bit of a warning in the changelog as the psycopg2 package requires build tools, libpq, etc, whereas before the psycopg2-binary package did not. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Okay, which makes me want to re-evaluate what benefit this change would give us. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Well, really I think users should have the choice between the binary or non-binary version depending on their circumstances. The only option for this I believe would be to remove the requirement entirely and tell users in the docs that one of them is required for table creation/migrations. This also allows the flexibility of running your migrations entirely separately from your web server. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Then let's drop psycopg2 and pymysql entirely, and make sure that the next version is a proper version bump, and calls out the requirement to install a sync driver if you're using alembic or SQL Alchemy's engine.create_all() |
Sorry, something went wrong.
retnikt
added a commit
to retnikt/databases
that referenced
this pull request
May 1, 2020
retnikt
added a commit
to retnikt/databases
that referenced
this pull request
May 1, 2020
TODO: set release information
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 19, 2020
Changelog: - Use backend native fetch_val() implementation when available (encode#132) - Replace psycopg2-binary with psycopg2 (encode#198) (encode#204) - Speed up PostgresConnection fetch() and iterate() (encode#193) - Access asyncpg Record field by key on raw query (encode#207) - Fix type hinting for sqlite backend (encode#227) - Allow setting min_size and max_size in postgres DSN (encode#210) - Add option pool_recycle in postgres DSN (encode#233) - Fix SQLAlchemy DDL statements (encode#226) - Make fetch_val call fetch_one for type conversion (encode#246) - Allow extra transaction options (encode#242) - Unquote username and password in DatabaseURL (encode#248)
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 19, 2020
Changelog: - Use backend native fetch_val() implementation when available (encode#132) - Replace psycopg2-binary with psycopg2 (encode#198) (encode#204) - Speed up PostgresConnection fetch() and iterate() (encode#193) - Access asyncpg Record field by key on raw query (encode#207) - Fix type hinting for sqlite backend (encode#227) - Allow setting min_size and max_size in postgres DSN (encode#210) - Add option pool_recycle in postgres DSN (encode#233) - Fix SQLAlchemy DDL statements (encode#226) - Make fetch_val call fetch_one for type conversion (encode#246) - Allow extra transaction options (encode#242) - Unquote username and password in DatabaseURL (encode#248)
Merged
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 20, 2020
Changelog: - Use backend native fetch_val() implementation when available (encode#132) - Replace psycopg2-binary with psycopg2 (encode#198) (encode#204) - Speed up PostgresConnection fetch() and iterate() (encode#193) - Access asyncpg Record field by key on raw query (encode#207) - Fix type hinting for sqlite backend (encode#227) - Allow setting min_size and max_size in postgres DSN (encode#210) - Add option pool_recycle in postgres DSN (encode#233) - Fix SQLAlchemy DDL statements (encode#226) - Make fetch_val call fetch_one for type conversion (encode#246) - Allow extra transaction options (encode#242) - Unquote username and password in DatabaseURL (encode#248)
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 20, 2020
Changelog: - Use backend native fetch_val() implementation when available (encode#132) - Replace psycopg2-binary with psycopg2 (encode#198) (encode#204) - Speed up PostgresConnection fetch() and iterate() (encode#193) - Access asyncpg Record field by key on raw query (encode#207) - Fix type hinting for sqlite backend (encode#227) - Allow setting min_size and max_size in postgres DSN (encode#210) - Add option pool_recycle in postgres DSN (encode#233) - Fix SQLAlchemy DDL statements (encode#226) - Make fetch_val call fetch_one for type conversion (encode#246) - Allow extra transaction options (encode#242) - Unquote username and password in DatabaseURL (encode#248)
vmarkovtsev
added a commit
that referenced
this pull request
Oct 20, 2020
Changelog: - Use backend native fetch_val() implementation when available (#132) - Replace psycopg2-binary with psycopg2 (#198) (#204) - Speed up PostgresConnection fetch() and iterate() (#193) - Access asyncpg Record field by key on raw query (#207) - Fix type hinting for sqlite backend (#227) - Allow setting min_size and max_size in postgres DSN (#210) - Add option pool_recycle in postgres DSN (#233) - Fix SQLAlchemy DDL statements (#226) - Make fetch_val call fetch_one for type conversion (#246) - Allow extra transaction options (#242) - Unquote username and password in DatabaseURL (#248)
Copy link
Copy Markdown
Contributor
|
Here I am, the one who released 0.4.0 and broke my own production builds because of this 😓 So shall I remove these requirements completely then? |
Sorry, something went wrong.
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 21, 2020
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 21, 2020
vmarkovtsev
added a commit
to vmarkovtsev/databases
that referenced
this pull request
Oct 21, 2020
vmarkovtsev
added a commit
that referenced
this pull request
Nov 16, 2020
niurkacanals
added a commit
to niurkacanals/databases-sql-expert
that referenced
this pull request
Sep 2, 2022
dudleyhunt86
added a commit
to dudleyhunt86/database-Django
that referenced
this pull request
Oct 7, 2022
adamharris1219
added a commit
to adamharris1219/database-Scripts
that referenced
this pull request
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.