FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove psycopg2 and pymysql from the direct dependencies by vmarkovtsev · Pull Request #256 · encode/databases · GitHub

This repository was archived by the owner on Aug 19, 2025. It is now read-only.
/ databases Public archive

Remove psycopg2 and pymysql from the direct dependencies - #256

Merged
vmarkovtsev merged 1 commit into
encode:masterfrom
vmarkovtsev:master
Nov 16, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Remove psycopg2 and pymysql from the direct dependencies#256
vmarkovtsev merged 1 commit into
encode:masterfrom
vmarkovtsev:master

Conversation

vmarkovtsev commented Oct 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #204

This should fix my own builds and I guess other people's too.

vmarkovtsev commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

cc @retnikt

daviskirk commented Oct 21, 2020

Copy link
Copy Markdown

Haven't upgraded but I know that the binary/non-binary problem has gotten me before, especially when trying to explain to others what they have to do to not get errors when installing stuff. So just having everyone decide what they want as suggested here is probably better.

pythoninja mentioned this pull request Oct 21, 2020
Closed

subdavis commented Oct 22, 2020 •
edited
Loading

Copy link
Copy Markdown

Just to be clear, this broke build for everyone who uses databases[postgresql] and psycopg2-binary, right?

I'm surprised there isn't more voting/commenting on this thread, and no back-refs from other projects to this issue.

For anyone playing along at home, "databases[postgresql]<0.4.0", should temporarily fix your build errors.

Thanks for all the hard work, btw :)

vmarkovtsev commented Oct 22, 2020

Copy link
Copy Markdown
Contributor Author

Version pinning ftw, yes. There is another option:

databases==0.4.0
asyncpg==0.21.0

polyrand commented Oct 22, 2020

Copy link
Copy Markdown

Yes, this broke my builds too. I think the option given by Tom: #204 (comment) is very reasonable. Thanks for the fast response and the work done on this!

vmarkovtsev commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

@encode/maintainers can please somebody approve this deal breaking fix.

rsommerard commented Nov 16, 2020 •
edited
Loading

Copy link
Copy Markdown

I'm having this issue too, please consider this PR.

florimondmanca approved these changes Nov 16, 2020
View reviewed changes

florimondmanca left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sounds good — let's consider a 0.5.0 bump perhaps. (Or, alternatively, let's skip bumping versions in this PR, and issue a proper release PR later when we're ready to issue 0.5.0.)

Comment thread CHANGELOG.md
Comment on lines +7 to +12
## 0.4.1 (October 21st, 2020)

### Fixed

* Remove package dependency on the synchronous DB drivers (#256)

florimondmanca Nov 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are we okay with bumping to 0.5.0? I think this qualifies as an entry for a "Changed" section, rather than "Fixed". That way people that are currently pinned to 0.4.* will be fine.

I'm not sure I understood the broken build issue with these direct dependencies, though (edit: I assume that's related to 3.9 and the lack of wheels?) but I think sticking closer to SemVer is a good idea here?

vmarkovtsev Nov 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have literally no other features to release rather than the broken package installation of 0.4.0 😂 And it was planned for 0.4.0 long before I became a maintainer, so I honestly just overlooked this PR.

vmarkovtsev Nov 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Besides, we have to bump the version, otherwise it does not deploy to pypi and many people continue suffering.

Thanks for the approval, I will carry on with the release now.

florimondmanca Nov 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Makes sense!

vmarkovtsev merged commit 5b60ba8 into encode:master Nov 16, 2020

vmarkovtsev commented Nov 16, 2020

Copy link
Copy Markdown
Contributor Author

https://github.com/encode/databases/releases/tag/0.4.1

florimondmanca reviewed Nov 16, 2020
View reviewed changes
Comment thread CHANGELOG.md

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## 0.4.1 (October 21st, 2020)

florimondmanca Nov 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Btw, the release date is a bit out of sync now. :-)

Should be:

## 0.4.1 (November 16th, 2020)

florimondmanca mentioned this pull request Nov 16, 2020
Merged
frgfm mentioned this pull request Nov 17, 2020
Merged
dependabot Bot mentioned this pull request Mar 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

lovelydinosaur Awaiting requested review from lovelydinosaur
1 more reviewer
florimondmanca florimondmanca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL