FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

🔧 Fix timeout parsing error in `pyproject.toml` by YuriiMotov · Pull Request #16217 · fastapi/fastapi · GitHub

Repository navigation

🔧 Fix timeout parsing error in pyproject.toml - #16217

Closed
YuriiMotov wants to merge 3 commits into
masterfrom
fix-timeout-parsing-error-in-pyproject.toml
Closed

YuriiMotov wants to merge 3 commits into
masterfrom
fix-timeout-parsing-error-in-pyproject.toml

Conversation

YuriiMotov commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

pytest-timeout released 2.5.0 and since this version it requires timeout to be specified as float, but older versions require it to be specified as string.

In tests we install locked version (2.4.0) and it works, but test-redistribute workflow installs latest version (2.5.0) and fails.

INTERNALERROR> TypeError: /home/runner/work/fastapi/fastapi/dist/fastapi-0.141.1/pyproject.toml: config option 'timeout' expects a float, got str: '20'

See related PR: pytest-dev/pytest-timeout#200

The only solution I see is to ignore the Dependabot's cooldown config and bump pytest-timeout to 2.5.0

AI Disclaimer

Didn't use AI

Checklist

  • This PR links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • The documentation explains the change if needed.

github-actions Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📝 Docs preview

Last commit 4cf5dbb at: https://bfdc965d.fastapitiangolo.pages.dev

YuriiMotov marked this pull request as draft August 17, 2026 08:28
YuriiMotov force-pushed the fix-timeout-parsing-error-in-pyproject.toml branch from 85066cf to 2a58158 Compare August 17, 2026 08:32
YuriiMotov marked this pull request as ready for review August 17, 2026 08:43

codspeed Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing fix-timeout-parsing-error-in-pyproject.toml (4cf5dbb) with master (a1fa70d)

YuriiMotov marked this pull request as draft August 17, 2026 08:46
YuriiMotov force-pushed the fix-timeout-parsing-error-in-pyproject.toml branch from 803f5d1 to 4cf5dbb Compare August 17, 2026 08:59
YuriiMotov marked this pull request as ready for review August 17, 2026 09:19

Copy link
Copy Markdown
Member Author

Not needed as pytest-timeout 2.5.0 has just been yanked: pytest-dev/pytest-timeout#200 (comment)

YuriiMotov closed this Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL