declare timeout ini options as float - #200
Merged
flub merged 1 commit intoAug 16, 2026
Merged
flub merged 1 commit into
flub merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
D0NGU1D0
approved these changes
Aug 12, 2026
flub
approved these changes
Aug 16, 2026
flub
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
|
That seems to be a breaking change - there is no way now to configure timeout in a way compatible with both 2.5.0 and 2.4.0: 2.5.0 strictly requires float: INTERNALERROR> TypeError: /home/yurii/code/1.FastAPI/fastapi/pyproject.toml: config option 'timeout' expects a float, got str: '20.0' 2.4.0 strictly requires string: INTERNALERROR> TypeError: /Users/runner/work/fastapi/fastapi/pyproject.toml: config option 'timeout' expects a string, got float: 20.0 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@YuriiMotov hum, sorry to miss that. I've yanked the 2.5 release on pypi until someone can look into this properly. Could you open a new issue for this? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194.
With pytest 9's native [tool.pytest] table, timeout = 1200 (a TOML int) makes the whole session die at configure time:
because timeout and session_timeout are registered with the default string ini type. Registering them with type="float" fixes it, matching what the values actually are. Legacy [pytest] ini strings like timeout = 2.5 still parse the same way, and timeout = 0 still means disabled (the > 0 checks are unchanged).
One catch: type="float" was added to addini in pytest 8.4, and registering it under 8.0.x fails at plugin load, so this bumps the floor in setup.cfg to pytest>=8.4.0. If keeping 8.0 support matters more, the alternative is a try/except shim around the registration; happy to switch if you prefer that.
Added a regression test using makepyprojecttoml with int values for both options (skipped below pytest 9, where the native table doesn't exist). Suite passes locally on 3.12: 35 passed, 21 skipped (the pexpect spawn skips, this is a Windows machine).