FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

馃摑 Update documentation to refer to `list` instead of `List` by bubbletroubles 路 Pull Request #1147 路 fastapi/sqlmodel 路 GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

馃摑 Update documentation to refer to list instead of List - #1147

Merged
tiangolo merged 4 commits into
fastapi:mainfrom
bubbletroubles:patch-1
Feb 28, 2025
ConversationCommits聽(4)ChecksFiles changed
Merged

馃摑 Update documentation to refer to list instead of List#1147
tiangolo merged 4 commits into
fastapi:mainfrom
bubbletroubles:patch-1

Conversation

bubbletroubles commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

All of the examples use lowercase list, but this text referrers to List (which is imported from Typing).

I suspect it's supposed to be lowercase.

github-actions Bot added the docs Improvements or additions to documentation label Oct 26, 2024
bubbletroubles changed the title Possible typo - List instead of list Docs - Possible typo - List instead of list Oct 26, 2024

github-actions Bot commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

馃摑 Docs preview for commit 74008c6 at: https://55dfa7c7.sqlmodel.pages.dev

Modified Pages

svlandeg changed the title Docs - Possible typo - List instead of list 馃摑 Update documentation to refer to list instead of List Feb 24, 2025
svlandeg reviewed Feb 24, 2025
View reviewed changes

svlandeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution!

Yes - this is a good catch. The older Python 3.7 examples do use List, but it makes sense to update the surrounding text to reflect the newest examples. In fact, I searched through the documentation and there's more cases like this, still referring to List. I'll take this opportunity to update all of them.

svlandeg marked this pull request as draft February 24, 2025 09:54
svlandeg self-assigned this Feb 24, 2025

github-actions Bot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

馃摑 Docs preview for commit 7ba67fa at: https://471b13fc.sqlmodel.pages.dev

Modified Pages

svlandeg marked this pull request as ready for review February 24, 2025 10:05

github-actions Bot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

馃摑 Docs preview for commit 2c5fc8c at: https://5b6b978a.sqlmodel.pages.dev

Modified Pages

svlandeg approved these changes Feb 24, 2025
View reviewed changes

svlandeg left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this should be ready to merge! 馃帀

svlandeg removed their assignment Feb 26, 2025

github-actions Bot commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

馃摑 Docs preview for commit 668bb2f at: https://bfc038a7.sqlmodel.pages.dev

Modified Pages

svlandeg mentioned this pull request Feb 28, 2025
Closed
tiangolo approved these changes Feb 28, 2025
View reviewed changes

tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great, thank you @bubbletroubles and @svlandeg! 馃 馃嵃

tiangolo merged commit 1bd5f27 into fastapi:main Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiangolo tiangolo approved these changes
svlandeg svlandeg approved these changes

Assignees

No one assigned

Labels

docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL