Repository navigation
Update docs for response-model - #1313
Closed
junhl wants to merge 1 commit into
Closed
junhl wants to merge 1 commit into
junhl wants to merge 1 commit into
Conversation
junhl
commented
Feb 27, 2025
Comment thread
docs/tutorial/fastapi/response-model.md
| We can also use other type annotations, the same way we can use with Pydantic fields. | ||
|
|
||
| First, we import `List` from `typing` and then we declare the `response_model` with `List[Hero]`: | ||
| For example, we can pass a list of `Hero`s to `response_model`. |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Moved For example, ... to new line like L33 for consistency.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
📝 Docs preview for commit 5935199 at: https://af6de111.sqlmodel.pages.dev Modified Pages |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi @junhl, thanks for contributing to sqlmodel! You're right, and there's already an open PR to address this: #1147 As the existing PR also includes additional cases that can be updated, we can continue the discussion there and I'll close this one. But thanks again! 🙏 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Python 3.9, you no longer have to use List from typing for type hinting.
The code example is updated but there is a sentence that was not updated accordingly in docs.