Repository navigation
✨ Add overload for exec method to support insert, update, delete statements - #1342
Merged
tiangolo merged 6 commits intoSep 17, 2025
Merged
tiangolo merged 6 commits into
tiangolo merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
seriaati
marked this pull request as draft
April 10, 2025 01:21
Copy link
Copy Markdown
|
On #1349 you asked for feedbacks on your PR: I tested it and it fixed my typing errors! Previously I had this mypy output: src/ddd/infrastructure/manager.py:263: error: No overload variant of "exec" of "Session" matches argument type "Update" [call-overload] src/ddd/infrastructure/manager.py:263: note: Possible overload variants: src/ddd/infrastructure/manager.py:263: note: def [_TSelectParam: Any] exec(self, statement: Select[_TSelectParam], *, params: Mapping[str, Any] | Sequence[Mapping[str, Any]] | None = ..., execution_options: Mapping[str, Any] = ..., bind_arguments: dict[str, Any] | None = ..., _parent_execute_state: Any | None = ..., _add_event: Any | None = ...) -> TupleResult[_TSelectParam] src/ddd/infrastructure/manager.py:263: note: def [_TSelectParam: Any] exec(self, statement: SelectOfScalar[_TSelectParam], *, params: Mapping[str, Any] | Sequence[Mapping[str, Any]] | None = ..., execution_options: Mapping[str, Any] = ..., bind_arguments: dict[str, Any] | None = ..., _parent_execute_state: Any | None = ..., _add_event: Any | None = ...) -> ScalarResult[_TSelectParam] After applying your patch, the type error is solved. |
Sorry, something went wrong.
YuriiMotov
approved these changes
Aug 15, 2025
YuriiMotov
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
This fixes the typing issue when we use exec method with insert, update or delete statements. Currently it works, but type checkers raise warnings. This PR fixes this.
@seriaati, thanks for working on this!
Sorry, something went wrong.
tiangolo
approved these changes
Sep 17, 2025
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #909