Repository navigation
✨ Allow deleting all rows from a table - #1349
Closed
jnewbery wants to merge 1 commit into
Closed
jnewbery wants to merge 1 commit into
jnewbery wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
svlandeg
marked this pull request as draft
April 28, 2025 09:12
jnewbery
marked this pull request as ready for review
May 6, 2025 09:54
Copy link
Copy Markdown
Author
|
Thanks for looking at this @svlandeg . I've fixed the failing pydantic error and marked this as ready for review. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This would be great to have – I just ran into this error! I think #1342 solves the same problem using UpdateBase, which covers update operations as well as delete ones. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sqlmodel docs explain how to delete a single row from a table.
It's also useful to be able to delete multiple rows (or even all rows) at the same time. See https://stackoverflow.com/questions/76648956/how-to-delete-all-rows-matching-a-condition-using-sqlmodel for example.
session.exec(delete(Table)) works fine, but triggers a type warning:
Adding an additional overload to Session.exec() allows this syntax to be used.