Repository navigation
✅ Add test that runs select with 3 or 4 arguments - #1590
Merged
tiangolo merged 7 commits intoOct 8, 2025
Merged
tiangolo merged 7 commits into
tiangolo merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
svlandeg
marked this pull request as ready for review
October 6, 2025 16:09
tiangolo
approved these changes
Oct 8, 2025
tiangolo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice, let's get this in, thank you! 🚀
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that _expression_select_gen.py works properly and provides the right type hints for code that calls select() with 3 or 4 arguments.
Note that I already provided some code to call select with 5 arguments as well. This works and runs, but won't succeed on a mypy check, as reported before.
While I think this PR is useful on its own, it's also in preparation of #1560.