FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

⬆ Bump mypy from 1.4.1 to 1.18.2 by dependabot[bot] · Pull Request #1560 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

⬆ Bump mypy from 1.4.1 to 1.18.2 - #1560

Merged
svlandeg merged 21 commits into
mainfrom
dependabot/pip/mypy-1.18.1
Oct 8, 2025
ConversationCommits (21)ChecksFiles changed
Merged

⬆ Bump mypy from 1.4.1 to 1.18.2#1560
svlandeg merged 21 commits into
mainfrom
dependabot/pip/mypy-1.18.1

Conversation

dependabot Bot commented on behalf of github Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps mypy from 1.4.1 to 1.18.1.

Changelog

Sourced from mypy's changelog.

Mypy Release Notes

Next Release

Mypy 1.18

We’ve just uploaded mypy 1.18 to the Python Package Index (PyPI). Mypy is a static type checker for Python. This release includes new features, performance improvements and bug fixes. You can install it as follows:

python3 -m pip install -U mypy

You can read the full documentation for this release on Read the Docs.

Mypy Performance Improvements

Mypy 1.18 includes numerous performance improvements, resulting in about 40% speedup compared to 1.17 when type checking mypy itself. In extreme cases, the improvement can be 10x or higher. The list below is an overview of the various mypy optimizations. Many mypyc improvements (discussed in a separate section below) also improve performance.

Type caching optimizations have a small risk of causing regressions. When reporting issues with unexpected inferred types, please also check if --disable-expression-cache will work around the issue, as it turns off some of these optimizations.

  • Improve self check performance by 1.8% (Jukka Lehtosalo, PR 19768, 19769, 19770)
  • Optimize fixed-format deserialization (Ivan Levkivskyi, PR 19765)
  • Use macros to optimize fixed-format deserialization (Ivan Levkivskyi, PR 19757)
  • Two additional micro‑optimizations (Ivan Levkivskyi, PR 19627)
  • Another set of micro‑optimizations (Ivan Levkivskyi, PR 19633)
  • Cache common types (Ivan Levkivskyi, PR 19621)
  • Skip more method bodies in third‑party libraries for speed (Ivan Levkivskyi, PR 19586)
  • Simplify the representation of callable types (Ivan Levkivskyi, PR 19580)
  • Add cache for types of some expressions (Ivan Levkivskyi, PR 19505)
  • Use cache for dictionary expressions (Ivan Levkivskyi, PR 19536)
  • Use cache for binary operations (Ivan Levkivskyi, PR 19523)
  • Cache types of type objects (Ivan Levkivskyi, PR 19514)
  • Avoid duplicate work when checking boolean operations (Ivan Levkivskyi, PR 19515)
  • Optimize generic inference passes (Ivan Levkivskyi, PR 19501)
  • Speed up the default plugin (Jukka Lehtosalo, PRs 19385 and 19462)
  • Remove nested imports from the default plugin (Ivan Levkivskyi, PR 19388)
  • Micro‑optimize type expansion (Jukka Lehtosalo, PR 19461)
  • Micro‑optimize type indirection (Jukka Lehtosalo, PR 19460)
  • Micro‑optimize the plugin framework (Jukka Lehtosalo, PR 19464)
  • Avoid temporary set creation in subtype checking (Jukka Lehtosalo, PR 19463)
  • Subtype checking micro‑optimization (Jukka Lehtosalo, PR 19384)
  • Return early where possible in subtype check (Stanislav Terliakov, PR 19400)
  • Deduplicate some types before joining (Stanislav Terliakov, PR 19409)
  • Speed up type checking by caching argument inference context (Jukka Lehtosalo, PR 19323)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 12, 2025
dependabot Bot mentioned this pull request Sep 12, 2025
Closed
github-actions Bot added the internal Internal changes label Sep 12, 2025
⬆ Bump mypy from 1.4.1 to 1.18.1
744954b 
Bumps [mypy](https://github.com/python/mypy) from 1.4.1 to 1.18.1.
- [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md)
- [Commits](python/mypy@v1.4.1...v1.18.1)

---
updated-dependencies:
- dependency-name: mypy
  dependency-version: 1.18.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot Bot force-pushed the dependabot/pip/mypy-1.18.1 branch from f54feaf to 744954b Compare September 16, 2025 08:57
svlandeg self-assigned this Sep 16, 2025
svlandeg reviewed Sep 16, 2025
View reviewed changes
Comment thread requirements-tests.txt Outdated
svlandeg changed the title ⬆ Bump mypy from 1.4.1 to 1.18.1 ⬆ Bump mypy from 1.4.1 to 1.14.1 Sep 16, 2025
svlandeg reviewed Sep 16, 2025
View reviewed changes
Comment thread sqlmodel/_compat.py

def get_annotations(class_dict: Dict[str, Any]) -> Dict[str, Any]:
return class_dict.get("__annotations__", {})
return class_dict.get("__annotations__", {}) # type: ignore[no-any-return]

svlandeg Sep 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As on L425, where we're already ignoring it, the error is

Returning Any from function declared to return "dict[str, Any]" [no-any-return]

svlandeg commented Sep 16, 2025

Copy link
Copy Markdown
Member

Huh. On Python 3.9 the CI is failing with

sqlmodel/main.py:39: error: X | Y syntax for unions requires Python 3.10 [syntax]

But I don't see a single X | Y in main.py 🤔

svlandeg commented Sep 16, 2025

Copy link
Copy Markdown
Member

The mypy check also takes super long, both on CI as locally. Weird - I keep investigating.

svlandeg marked this pull request as draft September 16, 2025 18:51
svlandeg previously requested changes Sep 16, 2025
View reviewed changes

svlandeg left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The false positive notifications of the X | Y syntax go away when specifying from __future__ import annotations at the top of the file, as suggested here.

But even if this PR goes green, we shouldn't merge it. The mypy runs are still taking a ridiculous amount of time, something like 12-13 minutes. Each full CI run usually takes less than 1 minute when looking at current open PRs.

svlandeg mentioned this pull request Sep 16, 2025
Closed
svlandeg removed their assignment Sep 16, 2025

This comment was marked as outdated.

Sign in to view
github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Sep 26, 2025

This comment was marked as resolved.

Sign in to view
github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Sep 26, 2025
svlandeg mentioned this pull request Sep 26, 2025
Merged

svlandeg commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

With mypy 1.10.0 the execution time is still reasonable (but it's still a pretty old version of mypy - I'll keep investigating)

Update: ignoring sqlmodel.sql._expression_select_gen.py from the mypy checks avoids the minute-long run.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
svlandeg changed the title ⬆ Bump mypy from 1.4.1 to 1.14.1 ⬆ Bump mypy from 1.4.1 to 1.18.2 Sep 29, 2025

This comment was marked as outdated.

Sign in to view

github-actions Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f30beb2 at: https://d085961e.sqlmodel.pages.dev

svlandeg marked this pull request as ready for review September 29, 2025 15:00
svlandeg removed their assignment Sep 29, 2025
svlandeg mentioned this pull request Oct 6, 2025
Merged
svlandeg marked this pull request as draft October 7, 2025 08:06

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

📝 Docs preview

Last commit d787c3f at: https://76cacab2.sqlmodel.pages.dev

svlandeg marked this pull request as ready for review October 8, 2025 11:09
tiangolo approved these changes Oct 8, 2025
View reviewed changes

tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me, feel free to merge when ready @svlandeg 🚀

svlandeg commented Oct 8, 2025

Copy link
Copy Markdown
Member

🎉

svlandeg merged commit f751e1c into main Oct 8, 2025
28 checks passed
svlandeg deleted the dependabot/pip/mypy-1.18.1 branch October 8, 2025 11:10

YuriiMotov commented Oct 24, 2025

Copy link
Copy Markdown
Member

from __future__ import annotations added by this PR causes Pyright in strict mode to show Type of "Field" is partially unknown error: #1598

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiangolo tiangolo approved these changes
svlandeg svlandeg left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file internal Internal changes python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL