feat: Updated feast Go operator db stores - #4802
Closed
tmihalac wants to merge 44 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
- Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
dmartinol
reviewed
Dec 3, 2024
Comment thread
infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
Outdated
dmartinol
enabled auto-merge (squash)
December 3, 2024 16:50
dmartinol
approved these changes
Dec 3, 2024
…the CRD Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
auto-merge was automatically disabled
December 3, 2024 18:38
Head branch was pushed to by a user without write access
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
- Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…the CRD Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…PR-4771 # Conflicts: # infra/feast-operator/internal/controller/featurestore_controller_db_store_test.go
* chore: Updated testcontainers to support MilvusContainer Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * downgraded Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * updating libraries to downgrade singlestore to 1.7.2 Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * fixing lint issues post package upgrades Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> * downgraded pyarrow Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> --------- Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* Add support for db stores in feast go operator Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Added CR example for store persistence Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Fixed incorrect yaml tag in RegistryConfig struct Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Removed leftovers comments from hasAttrib function Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Added another check that object parameter type is the same as value type in hasAttrib Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Reverted latest commit Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…ing (feast-dev#4794) Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
fix dbstore types Signed-off-by: Tommy Hughes <tohughes@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* fix: sqlite adapter deprecation warning Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * fix: remove duplicate folder definition in ruff config Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update minimum ruff version and format files Signed-off-by: Matt Green <emgeee@users.noreply.github.com> --------- Signed-off-by: Matt Green <emgeee@users.noreply.github.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
) Lock the TypeScript minor version by using `~` instead of `^` in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment). After upgrading, the TypeScript compiler complained that the `long` package has no default export. Related fixes: - Add the latest `long` version as a direct dependency since our code uses it directly; no compilation errors with the latest version - The `long` package exports a `Long` class, so use a capital first letter in the import name to match that Signed-off-by: Harri Lehtola <peruukki@hotmail.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* Initial commit Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * refactoring types with FeastHandler Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no private image Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * removed log-level Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no empty list for default Role Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * fixing generated code Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * renamed auth condition and types Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * post rebase fixes Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * more renamings Signed-off-by: Daniele Martinoli <dmartino@redhat.com> --------- Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* add tls support to the operator Signed-off-by: Tommy Hughes <tohughes@redhat.com> * operator tls review fix: if statement Signed-off-by: Tommy Hughes <tohughes@redhat.com> * rebase fixes Signed-off-by: Tommy Hughes <tohughes@redhat.com> * authz rbac fixes Signed-off-by: Tommy Hughes <tohughes@redhat.com> --------- Signed-off-by: Tommy Hughes <tohughes@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* clean up dependency installation makefile tasks Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * rewrite lock-python-dependencies-all to be more DRY Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update environment setup docs Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update smoke test Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * small change Signed-off-by: Matt Green <emgeee@users.noreply.github.com> --------- Signed-off-by: Matt Green <emgeee@users.noreply.github.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
- Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…the CRD Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tchughesiv
requested changes
Dec 3, 2024
tchughesiv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@tmihalac seems you might need to rebase on an updated master? something got messed up with your last push
Sorry, something went wrong.
tchughesiv
requested changes
Dec 3, 2024
tchughesiv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
rebase needs to be fixed
Sorry, something went wrong.
tchughesiv
approved these changes
Dec 3, 2024
tchughesiv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
franciscojavierarceo
approved these changes
Dec 3, 2024
* Initial commit Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no private image Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * fixing generated code Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * renamed auth condition and types Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * more renamings Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * initial commit Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * oidc IT Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * with sample Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no private image Signed-off-by: Daniele Martinoli <dmartino@redhat.com> --------- Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
* fix envVar positioning Signed-off-by: Tommy Hughes <tohughes@redhat.com> * tls.SecretRef.Name Signed-off-by: Tommy Hughes <tohughes@redhat.com> --------- Signed-off-by: Tommy Hughes <tohughes@redhat.com>
* Add support for db stores in feast go operator Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Added CR example for store persistence Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Fixed incorrect yaml tag in RegistryConfig struct Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Removed leftovers comments from hasAttrib function Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Added another check that object parameter type is the same as value type in hasAttrib Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Reverted latest commit Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* Initial commit Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * refactoring types with FeastHandler Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no private image Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * removed log-level Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * no empty list for default Role Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * removed nameLabelKey, using serices.NameLabelKey Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * improved CRD comments and using IsLocalRegistry Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * fixing generated code Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * renamed auth condition and types Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * post rebase fixes Signed-off-by: Daniele Martinoli <dmartino@redhat.com> * more renamings Signed-off-by: Daniele Martinoli <dmartino@redhat.com> --------- Signed-off-by: Daniele Martinoli <dmartino@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
* add tls support to the operator Signed-off-by: Tommy Hughes <tohughes@redhat.com> * operator tls review fix: if statement Signed-off-by: Tommy Hughes <tohughes@redhat.com> * rebase fixes Signed-off-by: Tommy Hughes <tohughes@redhat.com> * authz rbac fixes Signed-off-by: Tommy Hughes <tohughes@redhat.com> --------- Signed-off-by: Tommy Hughes <tohughes@redhat.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
- Added tests for invalid store type for each of the feast service Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…the CRD Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…PR-4771 # Conflicts: # infra/feast-operator/test/api/featurestore_types_test.go
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Copy link
Copy Markdown
Member
|
@tmihalac can you update DCO here? (You can click in the UI) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains the changes and leftovers from 4771
Which issue(s) this PR fixes:
Fixes #4793
Fixes #4783