| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…val of features from vector similarity search Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
|
@HaoXuAI take a look at this PR, I've moved the retrieval implementation to retrieve_online_documents_v2 instead of using retrieve_online_documents. My recommendation is we eventually wipe both of these methods and embed retrieve_online_documents_v2 in get_online_features and have retrieve_online_documents call get_online_features. Based on the Milvus documentation and allowing more features to be returned, it makes sense to just incorporate this into get_online_features in my opinion. |
Sorry, something went wrong.
| port: Optional[int] = 19530 | ||
| index_type: Optional[str] = "FLAT" | ||
| metric_type: Optional[str] = "L2" | ||
| metric_type: Optional[str] = "COSINE" |
There was a problem hiding this comment.
Might be better to make it an enum now since there are multiple values
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah sounds good, mind if I do that in a follow up PR?
Sorry, something went wrong.
There was a problem hiding this comment.
yep, for sure
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04) ### Bug Fixes * Adding periodic check to fix the sporadic failures of the operator e2e tests. ([#4952](#4952)) ([1d086be](1d086be)) * Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee)) * Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f)) * Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962) * Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85)) * Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d)) * Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939)) * Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9)) * Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52)) * Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703)) * Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3)) * Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102)) * Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68)) * Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55)) ### Features * Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8)) * Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852)) * Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d)) * Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3)) * Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc)) * Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13)) * Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364)) * Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c)) * Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
This PR adds support for returning multiple fields when doing vector similarity search with Milvus.
The behavior is now as simple as:
Feature Store Enhancements
Utility Functions
Provider and Online Store Updates
Testing and Example Repositories
Key Modifications
sdk/python/feast/feature_store.py
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
sdk/python/feast/infra/online_stores/online_store.py
sdk/python/feast/infra/passthrough_provider.py
sdk/python/feast/infra/provider.py
sdk/python/feast/utils.py
sdk/python/tests/example_repos/example_rag_feature_repo.py
sdk/python/tests/foo_provider.py
sdk/python/tests/unit/online_store/test_online_retrieval.py
Which issue(s) this PR fixes:
Another one for #4364
Misc
N/A