fix: Changed Env Vars for e2e tests - #4975
Merged
tchughesiv merged 2 commits intoJan 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tchughesiv
reviewed
Jan 28, 2025
Comment thread
infra/feast-operator/test/e2e/e2e_test.go
Outdated
tchughesiv
reviewed
Jan 28, 2025
Comment thread
infra/feast-operator/test/e2e/e2e_test.go
Outdated
Comment thread
infra/feast-operator/test/e2e/e2e_test.go
Outdated
Comment thread
infra/feast-operator/test/e2e/e2e_test.go
Outdated
Comment thread
infra/feast-operator/test/e2e/e2e_test.go
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tchughesiv
approved these changes
Jan 29, 2025
tchughesiv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
tchughesiv
enabled auto-merge (squash)
January 29, 2025 15:23
lokeshrangineni
approved these changes
Jan 29, 2025
franciscojavierarceo
approved these changes
Jan 29, 2025
Copy link
Copy Markdown
Member
|
hmmm, wonder why the tests aren't running |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@franciscojavierarceo I added the "go" label, expecting it to run all related Go code changes, including operator tests but it skipped tests like the operator e2e tests so I think we need adjust this label to include operator related test and exclude irrelevant tests. |
Sorry, something went wrong.
tchughesiv
pushed a commit
to tchughesiv/feast
that referenced
this pull request
Jan 30, 2025
* Changed Env Vars for e2e tests Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Made e2e changes following review Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tchughesiv
pushed a commit
to tchughesiv/feast
that referenced
this pull request
Jan 30, 2025
* Changed Env Vars for e2e tests Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Made e2e changes following review Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Tommy Hughes <tohughes@redhat.com>
tchughesiv
added a commit
that referenced
this pull request
Jan 30, 2025
* Changed Env Vars for e2e tests * Made e2e changes following review --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Tommy Hughes <tohughes@redhat.com> Co-authored-by: Theodor Mihalache <84387487+tmihalac@users.noreply.github.com>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Feb 4, 2025
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04) ### Bug Fixes * Adding periodic check to fix the sporadic failures of the operator e2e tests. ([#4952](#4952)) ([1d086be](1d086be)) * Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee)) * Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f)) * Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962) * Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85)) * Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d)) * Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939)) * Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9)) * Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52)) * Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703)) * Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3)) * Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102)) * Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68)) * Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55)) ### Features * Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8)) * Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852)) * Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d)) * Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3)) * Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc)) * Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13)) * Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364)) * Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c)) * Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added conditional run of BeforeAll in e2e tests, after the change it will not run in an OpeshiftCI environment since the OpeshiftCI infrastructure is responsible for the operations performed in BeforeAll
What this PR does / why we need it:
This change is need to enable e2e tests to be run with OpenshiftCI