fix: handle empty numpy arrays in scalar proto conversion during materialization - #6267
Closed
psaikaushik wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When a scalar feature column contains an empty numpy array (np.array([])),
pd.isnull() returns an array instead of a scalar bool. Applying Python's
`not` operator to that array raises:
ValueError: The truth value of an empty array is ambiguous.
This adds a safe null-check helper (is_scalar_null) that handles
array-like values before falling through to pd.isnull(). Empty arrays
are treated as null values, consistent with None and np.nan.
The helper is used in _convert_scalar_values_to_proto to replace the
bare `pd.isnull()` calls that crash on array inputs.
Closes feast-dev#6255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing — this is a duplicate of #6259 which was already opened by the issue author. Apologies for the noise.