FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: handle empty numpy arrays in scalar proto conversion during materialization by psaikaushik · Pull Request #6267 · feast-dev/feast · GitHub

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
56 changes: 56 additions & 0 deletions sdk/python/feast/null_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
"""Utilities for safely checking null/missing values in scalar columns.

The standard pd.isnull() is vectorized: when given a numpy array (including
an empty one), it returns an array of booleans instead of a scalar bool.
Applying Python's `not` operator to such an array raises:

ValueError: The truth value of an empty array is ambiguous.

These helpers wrap pd.isnull() to handle array-like values safely.

See: https://github.com/feast-dev/feast/issues/6255
"""

import numpy as np
import pandas as pd
from typing import Any


def is_scalar_null(value: Any) -> bool:
"""Check if a scalar value is null, safely handling array-like values.

Args:
value: A scalar value that might be None, NaN, or an array-like
object that ended up in a scalar feature column.

Returns:
True if the value should be treated as null/missing.
"""
# Fast path for common cases
if value is None:
return True
if isinstance(value, (str, bytes)):
return False

# Handle numpy arrays (including empty ones)
if isinstance(value, np.ndarray):
if value.size == 0:
return True
result = pd.isnull(value)
return bool(result.any()) if hasattr(result, "any") else bool(result)

# Handle other array-like objects (lists, tuples, etc.)
if hasattr(value, "__len__") and not isinstance(value, (str, bytes)):
try:
result = pd.isnull(value)
if hasattr(result, "any"):
return bool(result.any())
return bool(result)
except (ValueError, TypeError):
return False

# Plain scalar
try:
return bool(pd.isnull(value))
except (ValueError, TypeError):
return False
67 changes: 67 additions & 0 deletions sdk/python/tests/unit/test_null_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
"""Tests for feast.null_utils — safe null checking for scalar columns.

Reproduces the crash from https://github.com/feast-dev/feast/issues/6255
and verifies the fix handles all edge cases.
"""

import numpy as np
import pytest

from feast.null_utils import is_scalar_null


class TestIsScalarNull:
"""Tests for is_scalar_null."""

def test_none_is_null(self):
assert is_scalar_null(None) is True

def test_nan_is_null(self):
assert is_scalar_null(float("nan")) is True

def test_np_nan_is_null(self):
assert is_scalar_null(np.nan) is True

def test_empty_numpy_array_is_null(self):
"""This is the exact crash scenario from issue #6255."""
assert is_scalar_null(np.array([])) is True

def test_numpy_array_with_nan_is_null(self):
assert is_scalar_null(np.array([np.nan])) is True

def test_numpy_array_with_values_is_not_null(self):
assert is_scalar_null(np.array([1.0, 2.0])) is False

def test_int_is_not_null(self):
assert is_scalar_null(42) is False

def test_zero_is_not_null(self):
assert is_scalar_null(0) is False

def test_float_is_not_null(self):
assert is_scalar_null(3.14) is False

def test_string_is_not_null(self):
assert is_scalar_null("hello") is False

def test_empty_string_is_not_null(self):
assert is_scalar_null("") is False

def test_bytes_is_not_null(self):
assert is_scalar_null(b"data") is False

def test_bool_true_is_not_null(self):
assert is_scalar_null(True) is False

def test_bool_false_is_not_null(self):
assert is_scalar_null(False) is False

def test_np_bool_is_not_null(self):
assert is_scalar_null(np.bool_(True)) is False

def test_empty_list_is_null(self):
"""Empty list in a scalar column should be treated as null."""
assert is_scalar_null([]) is True

def test_list_with_values_is_not_null(self):
assert is_scalar_null([1, 2, 3]) is False

Back | FazBrowse Home | New Git URL