FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Keep tiling, offline and stream engine settings when copying a StreamFeatureView by Rodrigo-Palma · Pull Request #6924 · feast-dev/feast · GitHub

Repository navigation

fix: Keep tiling, offline and stream engine settings when copying a StreamFeatureView - #6924

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
Rodrigo-Palma:fix/stream-feature-view-copy
Oct 5, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
Rodrigo-Palma:fix/stream-feature-view-copy

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

StreamFeatureView.__copy__ doesn't pass offline, enable_tiling, tiling_hop_size or stream_engine to the constructor, so the copy falls back to the defaults. Since with_name, with_projection and __getitem__ all go through __copy__, a projected stream view silently loses tiling and its engine config. FeatureView.__copy__ already passes offline.

sfv = StreamFeatureView(..., offline=True, enable_tiling=True,
                        tiling_hop_size=timedelta(minutes=1),
                        stream_engine={"spark.sql.shuffle.partitions": "4"})
copy.copy(sfv).enable_tiling   # False
sfv == copy.copy(sfv)          # False (offline differs)

The registry also uses __copy__() to build the version snapshot for no_promote (registry.py:905), so that snapshot is saved without the tiling config.

Which issue(s) this PR fixes:

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Extended test_stream_feature_view_copy to set these fields; it fails on master and passes with the fix.

Rodrigo-Palma requested a review from a team as a code owner October 1, 2026 15:49

codecov-commenter commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.71%. Comparing base (66ff990) to head (9625bb4).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6924   +/-   ##
=======================================
  Coverage   48.71%   48.71%           
=======================================
  Files         427      427           
  Lines       53934    53934           
  Branches     7865     7865           
=======================================
  Hits        26272    26272           
  Misses      25789    25789           
  Partials     1873     1873           
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 50.08% <ø> (ø)
Files with missing lines Coverage Δ
sdk/python/feast/stream_feature_view.py 70.35% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ff990...9625bb4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jyejare force-pushed the fix/stream-feature-view-copy branch from a8bcd00 to 0f04038 Compare October 5, 2026 08:44

jyejare commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

@Rodrigo-Palma Please fix the checks failing.

Copy link
Copy Markdown
Contributor Author

@jyejare Both failures come from pixi install --locked ("lock file not up-to-date"): #6870 changed pyproject.toml without regenerating pixi.lock. #6940 fails the same way. This PR only touches stream_feature_view.py and its test.

…treamFeatureView

Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
jyejare force-pushed the fix/stream-feature-view-copy branch from 0f04038 to 9625bb4 Compare October 5, 2026 12:48
ntkathole merged commit fac0f88 into feast-dev:master Oct 5, 2026
22 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL