| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #6924 +/- ##
=======================================
Coverage 48.71% 48.71%
=======================================
Files 427 427
Lines 53934 53934
Branches 7865 7865
=======================================
Hits 26272 26272
Misses 25789 25789
Partials 1873 1873
Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
@Rodrigo-Palma Please fix the checks failing. |
Sorry, something went wrong.
|
@jyejare Both failures come from pixi install --locked ("lock file not up-to-date"): #6870 changed pyproject.toml without regenerating pixi.lock. #6940 fails the same way. This PR only touches stream_feature_view.py and its test. |
Sorry, something went wrong.
…treamFeatureView Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
StreamFeatureView.__copy__ doesn't pass offline, enable_tiling, tiling_hop_size or stream_engine to the constructor, so the copy falls back to the defaults. Since with_name, with_projection and __getitem__ all go through __copy__, a projected stream view silently loses tiling and its engine config. FeatureView.__copy__ already passes offline.
The registry also uses __copy__() to build the version snapshot for no_promote (registry.py:905), so that snapshot is saved without the tiling config.
Which issue(s) this PR fixes:
N/A
Checks
Testing Strategy
Extended test_stream_feature_view_copy to set these fields; it fails on master and passes with the fix.