FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Support Milvus partition keys in the Milvus online store by simonhearne · Pull Request #6940 · feast-dev/feast · GitHub

Repository navigation

feat: Support Milvus partition keys in the Milvus online store - #6940

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
simonhearne:feat/milvus-partition-key
Oct 7, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
simonhearne:feat/milvus-partition-key

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Multi-tenant feature views, such as a catalogue shared by many brands, benefit from Milvus
partition keys: a search filtered on the key only scans the matching partitions.

The partition key can be set per feature view with a tag, or for the whole store:

  • Feature view tag milvus.partition_key: <field>.
  • Store config partition_key: <field>, applied to every feature view that has that field.

The tag takes precedence. The field must be stored as VARCHAR or INT64; other types raise a clear
error. The setting only applies when Feast creates a collection: existing collections are left
alone, and Feast logs a warning explaining how to recreate them.

online_store:
  type: milvus
  partition_key: "brand_id"
FeatureView(
    name="products",
    ...,
    tags={"milvus.partition_key": "brand_id"},
)

Which issue(s) this PR fixes:

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests

  • Integration tests

  • Manual tests

  • Testing is not required for this change

  • Unit (Milvus Lite): the tag and the store config both mark the field as the partition key, and a
    filtered search returns only that tenant's rows; the store config is ignored for feature views
    without the field; the tag takes precedence over the config.

  • Unit (mocked client): a missing field and a FLOAT field are rejected; existing collections log a
    warning.

  • Server: the partition key is recorded in the collection schema and filtered search works.

Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0, a local Milvus 3.0.2 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.

Misc

Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895, #6917 and #6921.

simonhearne requested a review from a team as a code owner October 5, 2026 09:00

codecov-commenter commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.06%. Comparing base (6b212f5) to head (345d382).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../infra/online_stores/milvus_online_store/milvus.py 96.29% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6940      +/-   ##
==========================================
- Coverage   49.08%   49.06%   -0.03%     
==========================================
  Files         433      435       +2     
  Lines       54320    54528     +208     
  Branches     7915     7954      +39     
==========================================
+ Hits        26663    26752      +89     
- Misses      25781    25898     +117     
- Partials     1876     1878       +2     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 50.44% <96.29%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
.../infra/online_stores/milvus_online_store/milvus.py 76.17% <96.29%> (+3.38%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15533...345d382. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Multi-tenant feature views, such as a catalogue shared by many brands,
benefit from Milvus partition keys: searches filtered on the key only
scan the matching partitions.

A field can be marked as the partition key with the feature view tag
milvus.partition_key, or for every feature view containing the field
with the new partition_key store config. The tag takes precedence. The
field must be stored as VARCHAR or INT64.

Partition keys only apply when a collection is created. Feast logs a
warning when an existing collection lacks the configured key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
ntkathole force-pushed the feat/milvus-partition-key branch from 992f393 to 345d382 Compare October 7, 2026 06:48
ntkathole merged commit 0ed3285 into feast-dev:master Oct 7, 2026
18 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL