| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
⚠️ Please install the Codecov Report❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #6940 +/- ##
==========================================
- Coverage 49.08% 49.06% -0.03%
==========================================
Files 433 435 +2
Lines 54320 54528 +208
Branches 7915 7954 +39
==========================================
+ Hits 26663 26752 +89
- Misses 25781 25898 +117
- Partials 1876 1878 +2
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Multi-tenant feature views, such as a catalogue shared by many brands, benefit from Milvus partition keys: searches filtered on the key only scan the matching partitions. A field can be marked as the partition key with the feature view tag milvus.partition_key, or for every feature view containing the field with the new partition_key store config. The tag takes precedence. The field must be stored as VARCHAR or INT64. Partition keys only apply when a collection is created. Feast logs a warning when an existing collection lacks the configured key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
Multi-tenant feature views, such as a catalogue shared by many brands, benefit from Milvus
partition keys: a search filtered on the key only scans the matching partitions.
The partition key can be set per feature view with a tag, or for the whole store:
The tag takes precedence. The field must be stored as VARCHAR or INT64; other types raise a clear
error. The setting only applies when Feast creates a collection: existing collections are left
alone, and Feast logs a warning explaining how to recreate them.
Which issue(s) this PR fixes:
N/A
Checks
Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (Milvus Lite): the tag and the store config both mark the field as the partition key, and a
filtered search returns only that tenant's rows; the store config is ignored for feature views
without the field; the tag takes precedence over the config.
Unit (mocked client): a missing field and a FLOAT field are rejected; existing collections log a
warning.
Server: the partition key is recorded in the collection schema and filtered search works.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0, a local Milvus 3.0.2 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.
Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895, #6917 and #6921.