| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #6917 +/- ##
==========================================
+ Coverage 48.50% 48.52% +0.01%
==========================================
Files 427 427
Lines 53755 53774 +19
Branches 7827 7832 +5
==========================================
+ Hits 26076 26092 +16
- Misses 25813 25816 +3
Partials 1866 1866
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Search params were hard-coded to {"nprobe": 10} and index params to
{"nlist": nlist}. index_type: AUTOINDEX failed on Milvus servers and
Zilliz Cloud with "only metric type can be passed when use AutoIndex",
because nlist and the collection name were sent as index params.
Adds optional index_params and search_params config fields that are
passed through to Milvus. When unset, the previous defaults are kept,
except that AUTOINDEX gets no params. The collection name is no longer
passed as an index param. AUTOINDEX can now be tuned with the level
search param.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
Milvus search params were hard-coded to {"nprobe": 10} and index params to {"nlist": nlist}.
index_type: AUTOINDEX (the only option on Zilliz Cloud / managed Milvus) failed with
only metric type can be passed when use AutoIndex, for two reasons: nlist was always sent, and
collection_name was passed to IndexParams.add_index, which treats unknown kwargs as index params.
Which issue(s) this PR fixes:
N/A
Checks
Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (mocked client): default params unchanged for IVF_FLAT; AUTOINDEX sends only the metric;
HNSW index_params/search_params pass through.
Unit (Milvus Lite): AUTOINDEX + level search round trip.
Server: AUTOINDEX collection is created and searchable with level: 2.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.
Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882 and #6895.