Repository navigation
feat: Add consistency_level to the Milvus online store config - #6921
Merged
ntkathole merged 1 commit intoOct 4, 2026
Merged
ntkathole merged 1 commit into
ntkathole merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #6921 +/- ##
==========================================
+ Coverage 48.64% 48.71% +0.06%
==========================================
Files 427 427
Lines 53864 53934 +70
Branches 7849 7865 +16
==========================================
+ Hits 26203 26272 +69
+ Misses 25792 25789 -3
- Partials 1869 1873 +4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
ntkathole
approved these changes
Oct 4, 2026
Adds two optional settings, each Strong, Bounded, Session or Eventually: consistency_level is sent with every read and search, and collection_consistency_level is set when Feast creates a collection. When unset nothing is sent, so Milvus keeps its default (Bounded) exactly as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
ntkathole
force-pushed
the
feat/milvus-consistency-level
branch
from
706be05 to
ee7f255
Compare
October 4, 2026 13:08
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds two optional Milvus online store settings, each Strong, Bounded, Session or Eventually:
default for requests that don't specify a level, e.g. from other clients.
The two are independent. When they are unset nothing is sent, so Milvus keeps its default
(Bounded), which is the current behaviour.
With Bounded, a read issued straight after materialization may briefly miss the newest writes.
consistency_level: Strong makes Feast's reads always see the latest writes, at the cost of higher
read latency, and takes effect without recreating collections.
Which issue(s) this PR fixes:
N/A
Checks
Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (mocked client): neither level sent when unset; consistency_level sent only to query,
search and keyword query; collection_consistency_level sent only to create_collection;
different values for each are applied independently; invalid values rejected.
Server: collection level is Bounded by default and follows collection_consistency_level;
with consistency_level: Strong on a Bounded collection, a write is visible to the next read.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0, a local Milvus 3.0.2 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.
Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895 and #6917.