Repository navigation
fix: Map SQL Server bigint to INT64 and float to DOUBLE - #6950
Merged
ntkathole merged 1 commit intoOct 7, 2026
Merged
ntkathole merged 1 commit into
ntkathole merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #6950 +/- ##
==========================================
- Coverage 49.08% 49.01% -0.08%
==========================================
Files 433 435 +2
Lines 54320 54501 +181
Branches 7915 7947 +32
==========================================
+ Hits 26663 26712 +49
- Misses 25781 25914 +133
+ Partials 1876 1875 -1
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
ntkathole
approved these changes
Oct 7, 2026
mssql_to_feast_value_type mapped bigint to FLOAT, so 64-bit integer columns were inferred as Float32 and lost precision above 2^24. It also mapped float to FLOAT, but SQL Server float defaults to float(53), an 8-byte double. real (float(24)) stays FLOAT. Signed-off-by: LuisFigueroaG <luis.h.figueroa.g@gmail.com>
ntkathole
force-pushed
the
fix/mssql-bigint-type-mapping
branch
from
940e7bc to
cb7c491
Compare
October 7, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
mssql_to_feast_value_type (used by MsSqlServerSource schema inference) had two numeric types narrowed to a 32-bit float:
With the old mapping, bigint ID or count columns were inferred as Float32, which silently loses precision above 2^24, and float columns lost half their precision. This is the same kind of fix as #6629 for Postgres real.
Which issue(s) this PR fixes:
No existing issue.
Checks
Testing Strategy
Added a unit test for the SQL Server numeric mappings in test_type_map.py; it fails on master and passes with this change. ruff format --check, ruff check and mypy pass on the changed files.