Repository navigation
fix: Map Postgres real to FLOAT instead of DOUBLE - #6629
Merged
ntkathole merged 1 commit intoJul 30, 2026
Merged
ntkathole merged 1 commit into
ntkathole merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nikolauspschuetz
force-pushed
the
fix-pg-real-float-type-mapping
branch
from
c69419b to
291bee5
Compare
July 22, 2026 21:45
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #6629 +/- ##
==========================================
+ Coverage 46.35% 46.37% +0.01%
==========================================
Files 414 414
Lines 50052 50069 +17
Branches 7151 7153 +2
==========================================
+ Hits 23201 23217 +16
- Misses 25229 25230 +1
Partials 1622 1622
Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
nikolauspschuetz
marked this pull request as ready for review
July 25, 2026 19:26
jyejare
force-pushed
the
fix-pg-real-float-type-mapping
branch
from
291bee5 to
95a3240
Compare
July 28, 2026 09:07
ntkathole
force-pushed
the
fix-pg-real-float-type-mapping
branch
from
95a3240 to
5245ff5
Compare
July 30, 2026 06:20
ntkathole
approved these changes
Jul 30, 2026
Postgres real is a single-precision float4 column, but pg_type_to_feast_value_type mapped real to ValueType.DOUBLE (and real[] to DOUBLE_LIST), silently widening the inferred schema to float64. The mssql, oracle, and trino type maps in the same module all map real to FLOAT; only Postgres diverged. Map real to FLOAT and real[] to FLOAT_LIST to match. Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
ntkathole
force-pushed
the
fix-pg-real-float-type-mapping
branch
from
5245ff5 to
b519d00
Compare
July 30, 2026 08:30
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Postgres real is a single-precision (float4) column. pg_type_to_feast_value_type mapped it to ValueType.DOUBLE (and real[] to DOUBLE_LIST), silently widening the inferred feature schema to float64:
Every other DB type map in the same module maps real to FLOAT — mssql_to_feast_value_type, oracle_to_feast_value_type, and trino_to_feast_value_type. Only the Postgres map diverged. This maps real → FLOAT and real[] → FLOAT_LIST to match.
Test
Added test_pg_type_to_feast_value_type_real to the offline unit tests (sdk/python/tests/unit/test_type_map.py); it fails before this change and passes after.