| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
[pull] dove from feathersjs:dove
Feathersjs dove
- add module.exports for default export
|
This looks like a good step, thank you. I am seeing the same error locally you can see in CI:
I'm not sure what that means since all those packages have an identical configuration. |
Sorry, something went wrong.
✅ Deploy Preview for feathers-dove canceled.
|
Sorry, something went wrong.
Sorry, something went wrong.
|
Making a note here that the thing that may be missing is that the ESM and CJS folders each need a package.json that declares the module type like { "type": "module|commonjs" }Now that TypeScript seems to support it properly it might also make sense to use full imports with .js extensions. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This pull request adds ES module builds to all package distributables. It is backwards compatible by still providing the CommonJS version as well but will use ES modules in applications with "type": "module" (like the generated app) and with client side bundlers so it can use features like tree shaking.
Closes #2748
Closes #2001