Repository navigation
fix Websocket sent frame length - #59
Merged
fhessel merged 1 commit intoNov 24, 2019
Merged
fhessel merged 1 commit into
fhessel merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fhessel
self-requested a review
November 17, 2019 14:06
fhessel
approved these changes
Nov 24, 2019
fhessel
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
Good catch, approved. I should've seen that earlier, as the compile logs are quite clear bout this.
Regarding small and large frame lengths (126 or 127 in Payload len), I created #61 to track the progress.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, while testing the Websocket feature and reviewing the code, I found a typo that would lead to a wrong frame length sent when the frame data is larger than 126 bytes.
I also notice that there will still be an issue when the sent data is larger than 2^16 bytes because the frame length must be encoded on 7 + 64 bits in that case.