Repository navigation
avoid forced/implicit conversion - #60
Closed
george2209 wants to merge 3 commits into
Closed
george2209 wants to merge 3 commits into
george2209 wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
roll back to the master on this file
fhessel
self-requested a review
November 24, 2019 17:59
Copy link
Copy Markdown
Owner
|
Duplicate of #59. Sorry that I didn't get to review that other PR earlier, but thanks for pointing out that issue! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid forced/implicit conversion inside the WebsocketHandler::send