feat(rc): Support Remote Config managed value types (#1164) by ashish-kothari · Pull Request #1167 · firebase/firebase-admin-java · GitHub

Update Remote Config API to support managed value types

Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API.

Updated ParameterValue to include RolloutValue, PersonalizationValue, and ExperimentValue subclasses.
Added factory methods ofRollout, ofPersonalization, and ofExperiment to ParameterValue.
Updated TemplateResponse to parse rolloutValue, personalizationValue, and experimentValue fields from the backend response.
Added unit tests for the new value types.
Fixes Remote config publishTemplate override running rollouts #1092

Update Remote Config API to support managed value types Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API. - Updated `ParameterValue` to include `RolloutValue`, `PersonalizationValue`, and `ExperimentValue` subclasses. - Added factory methods `ofRollout`, `ofPersonalization`, and `ofExperiment` to `ParameterValue`. - Updated `TemplateResponse` to parse `rolloutValue`, `personalizationValue`, and `experimentValue` fields from the backend response. - Added unit tests for the new value types. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Summary of Changes

Hello @ashish-kothari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Firebase Remote Config API by introducing support for advanced managed value types. This change enables the system to handle more complex configuration scenarios, such as A/B testing, phased rollouts, and personalized content delivery, directly through the Remote Config parameters. The modifications involve extending existing data structures and parsing logic to accommodate these new capabilities.

Highlights

Support for Managed Value Types: The Remote Config API now supports managed value types, specifically Rollouts, Experiments, and Personalization, allowing for more dynamic configuration management.
ParameterValue Enhancements: The ParameterValue class has been updated to include new subclasses (RolloutValue, PersonalizationValue, ExperimentValue) and corresponding factory methods (ofRollout, ofPersonalization, ofExperiment) for creating these new types.
Template Response Parsing: The TemplateResponse class has been modified to correctly parse rolloutValue, personalizationValue, and experimentValue fields received from the backend.
Comprehensive Unit Tests: New unit tests have been added across various classes to ensure the correct creation, parsing, and equality checks for the newly introduced managed value types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Code Review

This pull request introduces support for managed value types (Rollouts, Experiments, and Personalization) in the Remote Config API. The changes are well-structured, adding new subclasses to ParameterValue, corresponding factory methods, and updating TemplateResponse to handle the new types from the backend. The unit tests are also updated to cover these new features. My review includes a critical fix for a potential JSON parsing issue due to a mismatched @Key annotation, suggestions to improve code conciseness using Java Streams, and a naming suggestion to enhance API consistency.

LGTM! Please make sure the doc strings are reviewed before merging

When will this be released ?
Any tentative ETA for this ?

@lahirumaramba @dsjadaun-google

By when can we expect a new release with this fix ?
This is breaking remote config pushes via SDK

@lahirumaramba @dsjadaun-google

By when can we expect a new release with this fix ? This is breaking remote config pushes via SDK
@UKMIITB

We are currently working on the next release, which will include this change. We will update this thread with progress. Thanks.

gemini-code-assist Bot reviewed Dec 31, 2025

View reviewed changes

ashish-kothari changed the title feat(rc)Support Remote Config managed value types (#1164) feat(rc): Support Remote Config managed value types (#1164) Dec 31, 2025

ashish-kothari requested a review from dsjadaun-google December 31, 2025 11:37

Resolve review comments

06c1848

ashish-kothari requested a review from lahirumaramba January 5, 2026 05:52

dsjadaun-google approved these changes Jan 5, 2026

View reviewed changes

Comment thread src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

Comment thread src/main/java/com/google/firebase/remoteconfig/ParameterValue.java Outdated

ashish-kothari added 4 commits January 7, 2026 12:19

Fix factory method when instantiating an explicit variant value

4797982

Fix lint issues

18bcd73

Fix oneof field serialization issue

0d1aeef

Handle default value scenario for rollout percent field

ad54883

lahirumaramba approved these changes Jan 21, 2026

View reviewed changes

ashish-kothari requested a review from nk-1983 January 22, 2026 09:07

nk-1983 approved these changes Jan 23, 2026

View reviewed changes

Merge branch 'main' into kotharas/rc-managed-values

4977cfd

ashish-kothari merged commit 584742f into main Feb 5, 2026
7 checks passed

lahirumaramba added release-note and removed release-note labels Feb 11, 2026

lahirumaramba deleted the kotharas/rc-managed-values branch February 17, 2026 14:49

ashish-kothari mentioned this pull request Feb 24, 2026

Add javadocs to public methods in RC managed value types #1187

Merged

rathovarun1032 mentioned this pull request Mar 25, 2026

feat(rc):Add exposurePercent to ExperimentValues #1201

Merged

feat(rc): Support Remote Config managed value types (#1164) by ashish-kothari · Pull Request #1167 · firebase/firebase-admin-java · GitHub

Uh oh!

feat(rc): Support Remote Config managed value types (#1164) - #1167

feat(rc): Support Remote Config managed value types (#1164)#1167
ashish-kothari merged 7 commits into
mainfrom
kotharas/rc-managed-values

ashish-kothari commented Dec 31, 2025 •
edited
Loading

Uh oh!

Uh oh!

gemini-code-assist Bot commented Dec 31, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lahirumaramba left a comment

Uh oh!

Uh oh!

UKMIITB commented Feb 9, 2026

Uh oh!

UKMIITB commented Feb 16, 2026

Uh oh!

lahirumaramba commented Feb 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(rc): Support Remote Config managed value types (#1164) by ashish-kothari · Pull Request #1167 · firebase/firebase-admin-java · GitHub

Uh oh!

feat(rc): Support Remote Config managed value types (#1164) - #1167

feat(rc): Support Remote Config managed value types (#1164)#1167ashish-kothari merged 7 commits intomainfirebase/firebase-admin-java:mainfrom kotharas/rc-managed-valuesfirebase/firebase-admin-java:kotharas/rc-managed-valuesCopy head branch name to clipboard

Conversation

ashish-kothari commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Dec 31, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lahirumaramba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UKMIITB commented Feb 9, 2026

Uh oh!

UKMIITB commented Feb 16, 2026

Uh oh!

lahirumaramba commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(rc): Support Remote Config managed value types (#1164)#1167
ashish-kothari merged 7 commits into
mainfrom
kotharas/rc-managed-values

ashish-kothari commented Dec 31, 2025 •
edited
Loading

lahirumaramba commented Feb 17, 2026 •
edited
Loading