FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(rc):Add exposurePercent to ExperimentValues by rathovarun1032 · Pull Request #1201 · firebase/firebase-admin-java · GitHub

feat(rc):Add exposurePercent to ExperimentValues - #1201

Merged
tusharkhandelwal8 merged 17 commits into
mainfrom
exposure-rc
Apr 27, 2026
Merged

feat(rc):Add exposurePercent to ExperimentValues#1201
tusharkhandelwal8 merged 17 commits into
mainfrom
exposure-rc

Conversation

rathovarun1032 commented Mar 24, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Add optional exposurePercent field to ExperimentValue to expose the
percentage of users included in an experiment. This follows up on #1167
which introduced the ExperimentValue type.

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Remote Config SDK by introducing an exposurePercent field to the ExperimentValue and ExperimentValueResponse classes. This change allows the system to store and retrieve the exposure percentage associated with an experiment, providing more comprehensive data for experiment management and analysis within the Remote Config framework.

Highlights

  • New Field Added: A new exposurePercent field of type Double was added to the ExperimentValue class in ParameterValue.java and ExperimentValueResponse in TemplateResponse.java.
  • Method Signature Update: The static factory method ParameterValue.ofExperiment was updated to accept the new exposurePercent parameter.
  • Deserialization Integration: The fromParameterValueResponse method in ParameterValue.java was modified to correctly deserialize and pass the exposurePercent when creating ExperimentValue instances.
  • Test Case Adjustments: Existing unit tests in ParameterValueTest.java were adjusted to reflect the new exposurePercent parameter in ExperimentValue creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

The pull request introduces an exposurePercent field to the ExperimentValue and ExperimentValueResponse classes, updating their constructors, factory methods, and serialization logic, and modifying existing test cases to include this new parameter. The review comments highlight several areas for improvement, including updating the equals and hashCode methods in ParameterValue.ExperimentValue to correctly incorporate exposurePercent, adding a getter for exposurePercent, updating the Javadoc for the ofExperiment method, removing an unused import in TemplateResponse.java, and adding an assertion for exposurePercent in ParameterValueTest.java.

rathovarun1032 changed the title Add exposurePercent to ExperimentValues feat(rc):Add exposurePercent to ExperimentValues Mar 25, 2026

lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Added a couple comments

lahirumaramba added release-note release:stage Stage a release candidate and removed release:stage Stage a release candidate labels Apr 9, 2026
tusharkhandelwal8 merged commit ab858ef into main Apr 27, 2026
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL