| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase Remote Config SDK by introducing an exposurePercent field to the ExperimentValue and ExperimentValueResponse classes. This change allows the system to store and retrieve the exposure percentage associated with an experiment, providing more comprehensive data for experiment management and analysis within the Remote Config framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
The pull request introduces an exposurePercent field to the ExperimentValue and ExperimentValueResponse classes, updating their constructors, factory methods, and serialization logic, and modifying existing test cases to include this new parameter. The review comments highlight several areas for improvement, including updating the equals and hashCode methods in ParameterValue.ExperimentValue to correctly incorporate exposurePercent, adding a getter for exposurePercent, updating the Javadoc for the ofExperiment method, removing an unused import in TemplateResponse.java, and adding an assertion for exposurePercent in ParameterValueTest.java.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
LGTM. Added a couple comments
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Add optional exposurePercent field to ExperimentValue to expose the
percentage of users included in an experiment. This follows up on #1167
which introduced the ExperimentValue type.