feat(fcm): Add image in notification support. - #298
Merged
chong-shao merged 5 commits intoAug 27, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
hiranya911
suggested changes
Aug 20, 2019
hiranya911
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks pretty good. Just a few suggestions.
Do we need to validate the imageUrl argument? (check not not empty and parse as a valid URL)
Sorry, something went wrong.
Comment thread
src/main/java/com/google/firebase/messaging/Notification.java
Outdated
Comment thread
src/test/java/com/google/firebase/messaging/FirebaseMessagingIT.java
Outdated
Comment thread
src/test/java/com/google/firebase/messaging/MessageTest.java
Outdated
Copy link
Copy Markdown
Contributor
Author
|
I think there's no need to validate the imageUrl argument since the HTTP API also does not do the check. |
Sorry, something went wrong.
hiranya911
approved these changes
Aug 27, 2019
hiranya911
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add image in notification support.
Testing
API Changes
RELEASE NOTE: Added new APIs for specifying an image URL in notifications.