feat(fcm): Added support for sending an image URL in notifications - #332
Merged
hiranya911 merged 8 commits intoSep 10, 2019
Merged
feat(fcm): Added support for sending an image URL in notifications#332hiranya911 merged 8 commits into
hiranya911 merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi @cchamm. Currently swamped with a couple of pending releases. Will take a look at this shortly. |
Sorry, something went wrong.
esp4ik
approved these changes
Sep 3, 2019
hiranya911
suggested changes
Sep 3, 2019
hiranya911
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks pretty good. Just need one addition.
Sorry, something went wrong.
Comment thread
firebase_admin/_messaging_utils.py
| def __init__(self, title=None, body=None, icon=None, color=None, sound=None, tag=None, | ||
| click_action=None, body_loc_key=None, body_loc_args=None, title_loc_key=None, | ||
| title_loc_args=None, channel_id=None): | ||
| title_loc_args=None, channel_id=None, image=None): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Need the same added to APNSFCMOptions. See firebase/firebase-admin-java#298
Sorry, something went wrong.
esp4ik
approved these changes
Sep 10, 2019
hiranya911
approved these changes
Sep 10, 2019
hiranya911
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329