FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add analytics_label in FcmOptions by chemidy · Pull Request #303 · firebase/firebase-admin-python · GitHub

/ firebase-admin-python Public

add analytics_label in FcmOptions - #303

Closed
chemidy wants to merge 4 commits into
firebase:masterfrom
chemidy:analytics_label
ConversationCommits (4)ChecksFiles changed
Closed

add analytics_label in FcmOptions#303
chemidy wants to merge 4 commits into
firebase:masterfrom
chemidy:analytics_label

Conversation

chemidy commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

-add analytics_label in FcmOptions

#301

stripathi669 commented Jul 3, 2019

Copy link
Copy Markdown

I came here to raise the same request. Thank you for that.

Any rough idea when can we see this in pypi release? In terms of (weeks or months etc)

chemidy commented Jul 3, 2019

Copy link
Copy Markdown
Contributor Author

I have to add tests and fix some bug in my PR before :)

hiranya911 suggested changes Jul 10, 2019
View reviewed changes

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks rather incomplete. I don't see the code that handles JSON serialization of new types. Also no test cases for the new functionality.

Comment thread firebase_admin/_messaging_utils.py
def __init__(self, analytics_label=None):
self.analytics_label = analytics_label

class FcmOptions(object):

hiranya911 Jul 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Add one more empty line.

Comment thread firebase_admin/_messaging_utils.py

def __init__(self, analytics_label=None):
self.analytics_label = analytics_label

hiranya911 Jul 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One more empty line.

hiranya911 mentioned this pull request Jul 19, 2019
Merged
hiranya911 closed this Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hiranya911 hiranya911 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL