FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(fcm): Analytics label based on @chemidy by willawang8908 · Pull Request #310 · firebase/firebase-admin-python · GitHub

feat(fcm): Analytics label based on @chemidy - #310

Merged
hiranya911 merged 7 commits into
firebase:masterfrom
willawang8908:analytics_label
Jul 19, 2019
Merged

feat(fcm): Analytics label based on @chemidy#310
hiranya911 merged 7 commits into
firebase:masterfrom
willawang8908:analytics_label

Conversation

willawang8908 commented Jul 19, 2019
edited by hiranya911
Loading

Copy link
Copy Markdown
Contributor

#301

RELEASE NOTE: Added support for specifying the analytics label for notifications.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Contributor Author

I signed it!

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Contributor Author

@googlebot I consent.

hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @willawang8908. Code looks good.

@chemidy can you put a comment indicating your consent, so we can proceed with this?

chemidy commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

Of course i'm ok with that you can merge it.

Copy link
Copy Markdown
Contributor

@chemidy You need to put a comment with the text @googlebot I consent

chemidy commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

@googlebot I consent

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

hiranya911 self-assigned this Jul 19, 2019

Copy link
Copy Markdown
Contributor

Closes #303

hiranya911 merged commit 8cf7291 into firebase:master Jul 19, 2019
hiranya911 changed the title Analytics label based on @chemidy feat(fcm): Analytics label based on @chemidy Aug 13, 2019

Copy link
Copy Markdown

@hiranya911 Can I check - when might you be planning to release this?

Copy link
Copy Markdown
Contributor

Most likely next week.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL