Fix and re-enable ctest desktop tests on x86 - #1043
Merged
dconeybe merged 19 commits intoAug 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
❌ Integration test FAILEDRequested by @dconeybe on commit af9c19f
Add flaky tests to go/fpl-cpp-flake-tracker |
Sorry, something went wrong.
…to avoid platform-specific %lu %llu, etc.
… not used anywhere
…on 32-bit platforms
dconeybe
marked this pull request as ready for review
August 5, 2022 20:09
…aitDelete' into MsToAbsoluteTimespecTest32BitGHATest
dconeybe
changed the base branch from
main
to
dconeybe/ConditionVariableTimedWaitDelete
August 6, 2022 00:31
jonsimantov
approved these changes
Aug 8, 2022
jonsimantov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice catch - we fixed this in the SDK itself in #939 but obviously the unit tests themselves were still broken.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review @jonsimantov! Do you have a minute to take a look at #1044 too? This PR depends on that PR being merged first, as it fixes another one of the failing x86 unit tests. |
Sorry, something went wrong.
Base automatically changed from
dconeybe/ConditionVariableTimedWaitDelete
to
main
August 8, 2022 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the few desktop unit tests that were failing on x86 due to non-portable coding bugs and re-enable the tests to run by GitHub Actions.