pthread_condvar.h: Fix ConditionVariable::TimedWait() on 32-bit platforms - #1044
Merged
dconeybe merged 3 commits intoAug 8, 2022
Merged
pthread_condvar.h: Fix ConditionVariable::TimedWait() on 32-bit platforms#1044dconeybe merged 3 commits into
dconeybe merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Integration test with FLAKINESS (succeeded after retry)Requested by @dconeybe on commit fdb50b0
Add flaky tests to go/fpl-cpp-flake-tracker |
Sorry, something went wrong.
jonsimantov
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the templated overload of ConditionVariable::TimedWait(), which suffers from the same integer overflow bug on 32-bit architectures as Semaphore::TimedWait(int) did (which was fixed by #1042). Also, delete NormalizeTimespec() since it is no longer used anywhere.