FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't redeclare inherited state in CredentialsProviderDesktop by schmidt-sebastian · Pull Request #731 · firebase/firebase-cpp-sdk · GitHub

Don't redeclare inherited state in CredentialsProviderDesktop - #731

Merged
schmidt-sebastian merged 1 commit into
mainfrom
mrschmidt/reusecredentials
Nov 29, 2021
Merged

Don't redeclare inherited state in CredentialsProviderDesktop#731
schmidt-sebastian merged 1 commit into
mainfrom
mrschmidt/reusecredentials

Conversation

schmidt-sebastian commented Nov 3, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

FIxes #729

google-cla Bot added the cla: yes label Nov 3, 2021
schmidt-sebastian force-pushed the mrschmidt/reusecredentials branch from dc2d430 to e5a058b Compare November 3, 2021 17:28
schmidt-sebastian added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Nov 23, 2021
github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 23, 2021

github-actions Bot commented Nov 23, 2021
edited
Loading

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @schmidt-sebastian on commit 11505cc
Last updated: Mon Nov 29 14:12 PST 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [Windows] [openssl](1 failed tests)  FirebaseFirestoreBasicTest.TestRunTransaction

Add flaky tests to go/fpl-cpp-flake-tracker

github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Nov 23, 2021
firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 23, 2021
schmidt-sebastian marked this pull request as ready for review November 23, 2021 19:50
schmidt-sebastian merged commit 11505cc into main Nov 29, 2021
github-actions Bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Nov 29, 2021
firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 29, 2021
DellaBitta added a commit that referenced this pull request Dec 1, 2021
* Fix test on emulator workflow failures (#734)

* If simulator  install ios app failed, reset simulator and try again (#733)

* Trigger workflow move github api cod to github.py (#746)

* Fix a data race that could manifest as null pointer dereference in FutureBase::Release() (#747)

* Cancel callbacks for messaging (#745)

* Cancel callbacks for messaging

util::Terminate is referenced counted som when there ar more APIs than messaging active the callbacks will not be canceled until later and still cause a NULL ref due to the FutureData being destroyed now.

* Cancel callback earlier

* Update readme

* Remove "Android" tag from the release notes entry for #747 (#749)

* Remove calls to LogInfo, LogError, LogDebug during obj-c +load. (#706)

* Remove calls to LogInfo, LogError, LogDebug during obj-c +load.

This could be causing an issue in C++ as global class constructors have not yet been run.

* Add Objective-C/C++ and Java to code formatter script; format those files. (#755)

* Allow format_code to format .m/.mm files; clang-format already knows how.

* Run format_code.py on all objective-c/objective-c++ files.

* Add Java file extensions to format_code.py

* Format all Java source files.

* Remove check for objc header, as they are now supported.

* Format objective-c .h files.

* Don't let lint comment on line length any more; code formatting will report that.

* Messaging crash during initialization (#760)

* Messaging crash during initialization

* Update readme

* Don't redeclare inherited state in CredentialsProviderDesktop (#731)

* Reduce disk space usage when packaging the built SDK (#763)

Remove intermediate build files during desktop packaging step.

This should reduce the disk space usage, as those files (*.o and *.obj) are not required when merging libraries.

* Workaround for Linux x86 build:  downgrade libraries on GitHub runners (#764)

When installing 32-bit Linux dependencies on GitHub runners, downgrade libpcre2-8-0 to an earlier version to ensure compatibility with the i386 version of the package. This is something that should be fixed in a subsequent Ubuntu release and so is a temporary workaround.

This also adds checks to the various prerequisite commands run by build_desktop.py, which was previously just silently ignoring errors (making this much harder to track down). Now it will error out as soon as a command fails.

Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com>
Co-authored-by: Denver Coneybeare <dconeybe@google.com>
Co-authored-by: Tobias Barendt <tobias@robotsquid.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>
Co-authored-by: Sebastian Schmidt <mrschmidt@google.com>
jonsimantov deleted the mrschmidt/reusecredentials branch December 22, 2021 22:38
firebase locked and limited conversation to collaborators Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Firestore: credentials_provider_desktop.h shadows members of superclass

2 participants


Back | FazBrowse Home | New Git URL