| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…tureBase::Release() (#747)
* Cancel callbacks for messaging util::Terminate is referenced counted som when there ar more APIs than messaging active the callbacks will not be canceled until later and still cause a NULL ref due to the FutureData being destroyed now. * Cancel callback earlier * Update readme
* Remove calls to LogInfo, LogError, LogDebug during obj-c +load. This could be causing an issue in C++ as global class constructors have not yet been run.
…iles. (#755) * Allow format_code to format .m/.mm files; clang-format already knows how. * Run format_code.py on all objective-c/objective-c++ files. * Add Java file extensions to format_code.py * Format all Java source files. * Remove check for objc header, as they are now supported. * Format objective-c .h files. * Don't let lint comment on line length any more; code formatting will report that.
* Messaging crash during initialization * Update readme
Remove intermediate build files during desktop packaging step. This should reduce the disk space usage, as those files (*.o and *.obj) are not required when merging libraries.
…#764) When installing 32-bit Linux dependencies on GitHub runners, downgrade libpcre2-8-0 to an earlier version to ensure compatibility with the i386 version of the package. This is something that should be fixed in a subsequent Ubuntu release and so is a temporary workaround. This also adds checks to the various prerequisite commands run by build_desktop.py, which was previously just silently ignoring errors (making this much harder to track down). Now it will error out as soon as a command fails.
| #include <stddef.h> | ||
| #include <stdint.h> | ||
|
|
||
| #include <mutex> |
There was a problem hiding this comment.
⚠️ Lint warning: <mutex> is an unapproved C++11 header.
Sorry, something went wrong.
There was a problem hiding this comment.
Should I // NOLINT this?
Sorry, something went wrong.
There was a problem hiding this comment.
Just FYI, this file's usage of std::mutex is going to be replaced with firebase::Mutex in the near future. Details are in b/206520921 if interested.
Sorry, something went wrong.
| #if defined(FIREBASE_USE_MOVE_OPERATORS) | ||
| inline FutureBase::FutureBase(FutureBase&& rhs) noexcept | ||
| : api_(NULL) // NOLINT | ||
| { |
There was a problem hiding this comment.
⚠️ Lint warning: { should almost always be at the end of the previous line
Sorry, something went wrong.
There was a problem hiding this comment.
Assuming everything builds + passes, LGTM.
Sorry, something went wrong.
❌ Integration test FAILEDRequested by @DellaBitta on commit 4b914d2
Add flaky tests to go/fpl-cpp-flake-tracker |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Changes:
Testing
Integration Tests CI
Type of Change
Place an x the applicable box:
Notes