Resolve VPC Connector region if REGION_TBD - #10469
Conversation
Sorry, something went wrong.
This dynamically resolves the VPC connector region to be the same as the function if not defined. This also includes a small comment fix for the region field in Endpoint.
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic resolution for VPC connector regions by replacing the REGION_TBD placeholder with the actual deployment region during the preparation phase. It includes updates to the Endpoint type documentation, logic in moveEndpointToRegion, and a new test case to verify the behavior. Review feedback recommends using the build.REGION_TBD constant instead of hardcoded string literals in both the implementation and the test code to maintain consistency and prevent typos.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This dynamically resolves the VPC connector region to be the same as the function if not defined. This also includes a small comment fix for the region field in Endpoint.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
shettyvarun268
left a comment
There was a problem hiding this comment.
LGTM!
Might want to re-run the failing checks and update the changelog for this
Sorry, something went wrong.
This dynamically resolves the VPC connector region to be the same as the function if not defined.
This also includes a small comment fix for the region field in Endpoint.
Scenarios Tested
Create function with VPC connector
firebase deploy --only functions on 15.16.0
Update function and use local firebase-tools build
firebase deploy --only functions
Update was successful.