refactor: resolve function regions during build phase to fix VPC connectors by wandamora · Pull Request #10471 · firebase/firebase-tools · GitHub

This moves the resolution logic to be before we resolve the build to a backend to set the defaults in functions, and the correct region can be known when building the VPC connector identfier.

Scenarios Tested

Create function with VPC connector
firebase deploy --only functions on 15.16.0
Update function and use local firebase-tools build
firebase deploy --only functions
Update was successful.

Code Review

This pull request refactors the region resolution logic for Cloud Functions, shifting the resolution process from the Backend representation to the Build representation. This allows for correct VPC connector string construction earlier in the deployment process. The new resolveDefaultRegionsForBuild function integrates existing region matching and trigger-based resolution. Review feedback identifies a violation of the style guide regarding the use of the any type and suggests including the endpoint ID in resolver calls to avoid potential issues. Additionally, a suggestion was made to use falsy checks for array length in accordance with project conventions.

LGTM

Might want to rebase this PR to take in Joe's changes for the test cases failing.

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Management Findings	-

Total	-

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

My AI review prompt had a few more good suggestions we can consider for a follow up PR.

This is done because endpoint (of type build.Endpoint) does not have an id field, but resolveRegionForEventTrigger expects a backend.Endpoint which requires an id. While this works, it bypasses TypeScript's type checks. Consider defining a minimal interface for what resolveRegionForEventTrigger actually needs (it seems to only need project and eventTrigger) or casting to a specific type that fulfills that contract rather than any.

Follow up: #10504

If a user has many event-triggered functions, this will execute network calls (like fetching database or bucket locations) sequentially (because of the for loop it's in), which can slow down the prepare phase. Consider gathering the promises and using Promise.all to resolve them in parallel.

Daniel once advised against using Promise.all() since transient errors could bubble up in the CLI in a way that looks cryptic to the end user.

#10414 (comment) for reference

Ok. That's a good counter argument. I think it'd be good for us to see what the cryptic error is and if we could fix it so things can be faster. But I guess let's save that for a day when we need to improve performance.

AI suggests also testing this case:

Pre-formatted VPC Connector Paths:
Scenario: An endpoint with a vpc.connector that is already a full resource path (e.g., projects/my-project/locations/us-east1/connectors/my-connector).
Purpose: Verify that the resolution logic does not attempt to prefix it again or corrupt it, even after the region is resolved. This ensures the check connector.includes("/") in build.ts works correctly in this flow.

Follow up: #10505

…ectors (#10471) * Attempt to resolve function regions earlier before used for VPC. * lint fixes * Check for REGION_TBD, update tests * Add CHANGELOG entry --------- Co-authored-by: Andy Perelson <ajp@google.com>

gemini-code-assist Bot reviewed May 7, 2026

View reviewed changes

Comment thread src/deploy/functions/prepare.ts

Comment thread src/deploy/functions/prepare.ts Outdated

wandamora changed the title Ajp speculative tbd fix yolo refactor: resolve function regions during build phase to fix VPC connectors May 7, 2026

wandamora marked this pull request as ready for review May 7, 2026 22:48

wandamora requested review from ajperel, joehan and shettyvarun268 May 7, 2026 22:51

wandamora mentioned this pull request May 7, 2026

Resolve VPC Connector region if REGION_TBD #10469

Closed

shettyvarun268 approved these changes May 8, 2026

View reviewed changes

wiz-9635d3485b Bot reviewed May 11, 2026

View reviewed changes

ajperel and others added 4 commits May 11, 2026 23:53

Attempt to resolve function regions earlier before used for VPC.

5f5fc36

lint fixes

c430297

Check for REGION_TBD, update tests

3d5694e

Add CHANGELOG entry

53f8bc3

wandamora force-pushed the ajp-speculative-tbd-fix-yolo branch from c9bded9 to 53f8bc3 Compare May 11, 2026 23:56

Merge branch 'main' into ajp-speculative-tbd-fix-yolo

d7f0725

wandamora enabled auto-merge (squash) May 12, 2026 15:31

wandamora merged commit a605414 into main May 12, 2026
52 checks passed

wandamora deleted the ajp-speculative-tbd-fix-yolo branch May 12, 2026 15:44

ajperel reviewed May 12, 2026

View reviewed changes

wandamora linked an issue May 26, 2026 that may be closed by this pull request

deploys with 15.17.0 fail without explicit setGlobalOptions({ region: 'us-central1' }) with vpcConnector #10467

Open

+                    } else {
+                      // Match triggers.
+                      try {
+                        const fullEndpoint = { ...endpoint, id } as any;

+                        if (build.isBlockingTriggered(endpoint)) {
+                          resolvedRegion = resolveRegionForBlockingTrigger(fullEndpoint);
+                        } else if (build.isEventTriggered(endpoint)) {
+                          resolvedRegion = await resolveRegionForEventTrigger(fullEndpoint);

+                    expect(want.endpoints["id"].region).to.deep.equal(["us-east1"]);
+                  });
+                  it("resolves region to us-east1 and correctly formats VPC connector path with us-east1", async () => {

refactor: resolve function regions during build phase to fix VPC connectors by wandamora · Pull Request #10471 · firebase/firebase-tools · GitHub

Uh oh!

refactor: resolve function regions during build phase to fix VPC connectors - #10471

refactor: resolve function regions during build phase to fix VPC connectors#10471wandamora merged 5 commits intomainfirebase/firebase-tools:mainfrom ajp-speculative-tbd-fix-yolofirebase/firebase-tools:ajp-speculative-tbd-fix-yoloCopy head branch name to clipboard

Conversation

wandamora commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scenarios Tested

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

shettyvarun268 left a comment

Choose a reason for hiding this comment

Uh oh!

shettyvarun268 commented May 8, 2026

Uh oh!

wiz-9635d3485b Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Wiz Scan Summary

Uh oh!

Uh oh!

ajperel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

refactor: resolve function regions during build phase to fix VPC connectors#10471
wandamora merged 5 commits into
mainfrom
ajp-speculative-tbd-fix-yolo

wandamora commented May 7, 2026 •
edited
Loading

wiz-9635d3485b Bot commented May 11, 2026 •
edited
Loading