Fix checkForNode8 issue - #2945
Merged
samtstern merged 2 commits intoDec 16, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bkendall
approved these changes
Dec 16, 2020
Copy link
Copy Markdown
|
Awesome speed in fixing the issue . Thanks a lot |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thank you for fixing this so quickly! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2944
Scenarios Tested
$ firebase deploy --only functions === Deploying to 'fir-dumpster'... i deploying functions i functions: ensuring required API cloudfunctions.googleapis.com is enabled... i functions: ensuring required API cloudbuild.googleapis.com is enabled... ✔ functions: required API cloudfunctions.googleapis.com is enabled ✔ functions: required API cloudbuild.googleapis.com is enabled i functions: preparing functions directory for uploading... i functions: packaged functions (24.53 KB) for uploading ✔ functions: functions folder uploaded successfully i functions: creating Node.js 12 function helloWorld(us-central1)... The following functions are found in your project but do not exist in your local source code: createToken(us-central1) helloworld(us-central1) onTestUpdate(us-central1) verifyToken(us-central1) If you are renaming a function or changing its region, it is recommended that you create the new function first before deleting the old one to prevent event loss. For more info, visit https://firebase.google.com/docs/functions/manage-functions#modify ? Would you like to proceed with deletion? Selecting no will continue the res t of the deployments. No i functions: continuing with other deployments. ✔ functions[helloWorld(us-central1)]: Successful create operation. Function URL (helloWorld): https://us-central1-fir-dumpster.cloudfunctions.net/helloWorld ✔ Deploy complete! Project Console: https://console.firebase.google.com/project/fir-dumpster/overviewSample Commands