FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix checkForNode8 issue by samtstern · Pull Request #2945 · firebase/firebase-tools · GitHub

/ firebase-tools Public

Fix checkForNode8 issue #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 2 commits into from
Dec 16, 2020
+2 −2
Conversation 2 Commits 2 Checks 0 Files changed 2
Merged

Fix checkForNode8 issue #2945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c7b8f
Fix checkForNode8 issue
samtstern Dec 16, 2020
d64641d
Merge branch 'master' into ss-fix-2944
samtstern Dec 16, 2020
File filter

Filter by extension

Filter by extension .js  (1) .md  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions CHANGELOG.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixes "checkForNode8 is not a function" issue in `firebase deploy` (#2944).
3 changes: 1 addition & 2 deletions src/deploy/functions/release.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ var friendlyRuntimeName = require("../../parseRuntimeAndValidateSDK").getHumanFr
var { getAppEngineLocation } = require("../../functionsConfig");
var { promptOnce } = require("../../prompt");
var { createOrUpdateSchedulesAndTopics } = require("./createOrUpdateSchedulesAndTopics");
var { checkForNode8 } = require("./checkRuntimeDependencies");

var deploymentTool = require("../../deploymentTool");
var timings = {};
Expand Down Expand Up @@ -527,7 +526,7 @@ module.exports = function(context, options, payload) {
deployments.length - failedDeployments.length
);
}
checkForNode8(runtime);

if (failedDeployments.length > 0) {
logger.info("\n\nFunctions deploy had errors with the following functions:");
const sortedFailedDeployments = failedDeployments.sort();
Expand Down
Back | FazBrowse Home | New Git URL