| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Require an explicit Logback appender opt-in before forwarding records as Sentry Logs. Keep event and breadcrumb capture independent while the aggregate core Logs flag remains in place. Co-Authored-By: Claude <noreply@anthropic.com>
|
Sorry, something went wrong.
📲 Install BuildsAndroid
|
Sorry, something went wrong.
There was a problem hiding this comment.
I put a global suggestion on the naming, probably worth a discussion with the team but otherwise going to approve
Sorry, something went wrong.
| public fun getMinimumBreadcrumbLevel ()Lch/qos/logback/classic/Level; | ||
| public fun getMinimumEventLevel ()Lch/qos/logback/classic/Level; | ||
| public fun getMinimumLevel ()Lch/qos/logback/classic/Level; | ||
| public fun isEnableLogs ()Z |
There was a problem hiding this comment.
would it be more idiomatic to make this logsEnabled()?
Sorry, something went wrong.
There was a problem hiding this comment.
Afaik other SDKs are calling the option enableLogs too, so I wanted to align.
Sorry, something went wrong.
There was a problem hiding this comment.
good point, this is the classic tension of consistency vs feeling native to the platform. Given our new goal hierarchy, I would think it should be the one that feels native.
Sorry, something went wrong.
There was a problem hiding this comment.
Discussed in slack, we should make this feel native.
Sorry, something went wrong.
There was a problem hiding this comment.
Adding my 2 cents here: I do believe the getter should still follow JavaBean conventions and be isLogsEnabled().
My reasoning here:
Sorry, something went wrong.
| public fun getMinimumEventLevel ()Lch/qos/logback/classic/Level; | ||
| public fun getMinimumLevel ()Lch/qos/logback/classic/Level; | ||
| public fun isEnableLogs ()Z | ||
| public fun setEnableLogs (Z)V |
There was a problem hiding this comment.
same suggestion as above
| public fun setEnableLogs (Z)V | |
| public fun setLogsEnabled (Z)V |
Sorry, something went wrong.
| private @NotNull Level minimumBreadcrumbLevel = Level.INFO; | ||
| private @NotNull Level minimumEventLevel = Level.ERROR; | ||
| private @NotNull Level minimumLevel = Level.INFO; | ||
| private boolean enableLogs = false; |
There was a problem hiding this comment.
| private boolean enableLogs = false; | |
| private boolean logsEnabled = false; |
Sorry, something went wrong.
There was a problem hiding this comment.
After a discussion, I think we should make this feel native!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Adds a logsEnabled option to the Logback SentryAppender. The option defaults to false and can be configured through Java or Logback XML.
The appender now requires both this local opt-in and the existing aggregate core Logs flag before forwarding Logback records as Sentry Logs. Event and breadcrumb capture remain unchanged.
💡 Motivation and Context
Logging integrations need explicit local opt-ins before the aggregate core Logs flag can be removed later in this stack. This prevents applications from unexpectedly forwarding framework logs when core Logs capture becomes available without a global enable flag.
💚 How did you test it?
📝 Checklist
🔮 Next steps
Continue adding integration-local Logs opt-ins before removing the aggregate core Logs flag.