FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: [Logs and Metrics Enable Flags 18] Update options guidance by adinauer · Pull Request #5961 · getsentry/sentry-java · GitHub

docs: [Logs and Metrics Enable Flags 18] Update options guidance - #5961

Open
adinauer wants to merge 2 commits into
fix/jul-null-log-messagefrom
docs/update-options-guidance
Open

docs: [Logs and Metrics Enable Flags 18] Update options guidance#5961
adinauer wants to merge 2 commits into
fix/jul-null-log-messagefrom
docs/update-options-guidance

Conversation

adinauer commented Aug 13, 2026
edited
Loading

Copy link
Copy Markdown
Member

PR Stack (Logs and Metrics Enable Flags)


📜 Description

Updates the repository's options guidance to match the Logs and Metrics configuration model introduced by this stack.

The rule now distinguishes deliberate API capture from automatic integrations, documents every integration-local Logs opt-in, and prevents future changes from restoring obsolete aggregate enable flags.

💡 Motivation and Context

The previous guidance instructed maintainers and coding agents to add and check aggregate enabled fields, bind sentry.logs.enabled, and apply Android aggregate metadata. Those instructions no longer compile or match the intended architecture after removal of the Logs and Metrics enable flags.

💚 How did you test it?

  • Reviewed the updated rule against core, Android, Spring Boot, and logging integration behavior in this stack
  • Searched the rule for stale aggregate API examples
  • ./gradlew spotlessApply apiDump

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Publish the user-facing Java and Android migration guide tracked separately for this stack.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Document always-available deliberate APIs, source-local automatic Logs opt-ins, and warning-only handling of obsolete aggregate settings.

Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 13, 2026

sentry Bot commented Aug 13, 2026
edited
Loading

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.52.0 (1) release

⚙️ sentry-android Build Distribution Settings

Comment thread .cursor/rules/options.mdc
- `enabled` boolean (default `false` for opt-in)
- `sampleRate` double (if the feature supports sampling)
- `beforeSend` callback interface (nested inside the options class)
Do not assume that a namespaced signal needs an aggregate `enabled` field. In particular, Logs and

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Will the agents be confused by the implications of logs and metrics having e.g. sampling? In the old version there was an explicit if the features supports... comment

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL